Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to reusable build workflow #330

Merged

Conversation

dprince
Copy link
Collaborator

@dprince dprince commented Oct 12, 2023

Shared github workflows and operator-sdk 1.31

This PR switches the operator to use shared build workflows
for building operator, bundle, and catalog/index images.

Additionally operator-sdk is bumped to 1.31. (also includes
bump to OPM and controller-gen)

Jira: OSP-29146
Jira: OSP-26858

@dprince dprince force-pushed the reusable-build-workflow branch 12 times, most recently from ace6e08 to cab177b Compare October 12, 2023 18:44
@dprince dprince marked this pull request as ready for review October 12, 2023 18:44
@openshift-ci openshift-ci bot requested review from frenzyfriday and viroel October 12, 2023 18:44
@dprince dprince changed the title Switch to reusable build workflow DO NOT MERGE: Switch to reusable build workflow Oct 12, 2023
This PR switches the operator to use shared build workflows
for building operator, bundle, and catalog/index images.

Additionally operator-sdk is bumped to 1.31. (also includes
bump to OPM and controller-gen)

Jira: OSP-29146
Jira: OSP-26858
@dprince dprince force-pushed the reusable-build-workflow branch from cab177b to 6e22fcd Compare October 12, 2023 22:36
@dprince dprince changed the title DO NOT MERGE: Switch to reusable build workflow Switch to reusable build workflow Oct 12, 2023
@dprince
Copy link
Collaborator Author

dprince commented Oct 13, 2023

/test keystone-operator-build-deploy-kuttl

Copy link
Contributor

@stuggi stuggi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

@abays abays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abays, dprince, stuggi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [abays,dprince,stuggi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot merged commit 3e445cd into openstack-k8s-operators:main Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants