Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kuttl tests for extramounts option #385

Merged

Conversation

ashu-011
Copy link
Contributor

@ashu-011 ashu-011 commented Nov 8, 2024

This commit updates the horizon deployment spec to incorporate extramounts mounting the file to a particular path and assert the resulting Deployment to verify that it contains the mountpoint destined to the file

@openshift-ci openshift-ci bot requested review from frenzyfriday and viroel November 8, 2024 13:29
@ashu-011 ashu-011 force-pushed the kuttl_extramount branch 2 times, most recently from 39f5036 to d077fb1 Compare November 8, 2024 14:45
@ashu-011
Copy link
Contributor Author

ashu-011 commented Nov 8, 2024

/test horizon-operator-build-deploy-kuttl

This commit updates the horizon deployment spec to
incorporate extramounts mounting the file to a particular
path and assert the resulting Deployment to verify that it
contains the mountpoint destined to the file
Copy link
Contributor

@fmount fmount left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@fmount
Copy link
Contributor

fmount commented Nov 11, 2024

@bshephar || @deshipu to /approve

Copy link
Contributor

openshift-ci bot commented Nov 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ashu-011, bshephar, deshipu, fmount

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 2ef2b1f into openstack-k8s-operators:main Nov 11, 2024
5 checks passed
@deshipu
Copy link
Contributor

deshipu commented Nov 12, 2024

/approve

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants