[repo_setup] Use a role scoped copy of url_request #2647
Merged
+2
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Thanks for the PR! ❤️ |
Since the role seems to be used from zuul without a nested playbook this role needs to have all of its dependencies self contained and not depending on global modules. To avoid copy/pasting the content of the module a symlink is used. This change is required for zuul to call this role from its executor.
pablintino
force-pushed
the
repo_setup-make-url_request-a-role-plugin
branch
from
71bbf57 to
b41fd27
Compare
|
/test images |
frenzyfriday
approved these changes
Jan 14, 2025
|
/test images |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the role seems to be used from zuul without a nested playbook this role needs to have all of its dependencies self contained and not depending on global modules. To avoid copy/pasting the content of the module a symlink is used.
This change is required for zuul to call this role from its executor.