Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define a new EDPM role for installing nvidia driver on nodes #2637

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sbauza
Copy link

@sbauza sbauza commented Jan 9, 2025

In order to do nvidia vGPU testing, we need to deploy a specific package on EDPM nodes and do some other actions.
This is a multi-stage role requring a reboot between the two stages hence the two defined phases.

Copy link
Contributor

openshift-ci bot commented Jan 9, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign cescgina for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented Jan 9, 2025

Hi @sbauza. Thanks for your PR.

I'm waiting for a openstack-k8s-operators member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

github-actions bot commented Jan 9, 2025

Thanks for the PR! ❤️
I'm marking it as a draft, once your happy with it merging and the PR is passing CI, click the "Ready for review" button below.

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/c18f1379352942ab958539d670a22b47

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 30m 40s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 17m 57s
cifmw-crc-podified-edpm-baremetal RETRY_LIMIT in 27m 37s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 7m 48s
cifmw-pod-pre-commit FAILURE in 5m 51s
✔️ cifmw-pod-zuul-files SUCCESS in 4m 08s
✔️ build-push-container-cifmw-client SUCCESS in 36m 27s
cifmw-molecule-edpm_nvidia_mdev_prepare FAILURE in 4m 15s

@sbauza
Copy link
Author

sbauza commented Jan 10, 2025

recheck

@SeanMooney
Copy link
Contributor

/ok-to-test

@sbauza
Copy link
Author

sbauza commented Jan 10, 2025

recheck

In order to do nvidia vGPU testing, we need to deploy a specific package on
EDPM nodes and do some other actions.
This is a multi-stage role requring a reboot between the two stages hence the
two defined phases.
@sbauza sbauza force-pushed the edpm_nvidia_mdev_prepare branch from 7c9fa6e to a8c455a Compare January 13, 2025 08:44
@sbauza sbauza marked this pull request as ready for review January 13, 2025 13:55
@hjensas
Copy link
Contributor

hjensas commented Jan 14, 2025

How would customers do this?
Would they not use a custom service interface, or the bootstrap command interface so that this type of package install is handled using the products interfaces?

Here is an example custom service for repo setup: https://github.com/openstack-k8s-operators/install_yamls/blob/main/devsetup/edpm/services/dataplane_v1beta1_openstackdataplaneservice_reposetup.yaml

At first glance, I am very much against this change. We should use the products features to do this kind of thing.

@slagle - wdyt?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants