Adoption ironic hook - IPA var/lib/ironic/httpboot #2629
Conversation
For inspection we need to add the ironic-python-agent to the /var/lib/ironic/httpboot folder. Update the hook to install the package on groups - osp-controllers and osp-underclouds, and copy the file to the appropriate location.
|
Thanks for the PR! ❤️ |
| ansible.builtin.setup: | ||
| gather_subset: | ||
| - user_dir | ||
| loop: | ||
| - controller-0 | ||
| - osp-undercloud-0 |
There was a problem hiding this comment.
Do we have a way to get these hosts from a group? Just in case we add/remove more.
There was a problem hiding this comment.
I don't think so, I tried to do this without a loop - i.e by doing when: inventory_hostname in group["group_name"] style condition - it failed on looking up the group. I think that approach would execute much faster ...
... side note - I think it would be much more efficient elsewhere as well - for example these "delegate_to" loops would be beneficial to run in parallel:
- https://github.com/openstack-k8s-operators/ci-framework/blob/main/roles/adoption_osp_deploy/tasks/prepare_overcloud.yml#L113
- https://github.com/openstack-k8s-operators/ci-framework/blob/main/roles/adoption_osp_deploy/tasks/prepare_overcloud.yml#L194
- https://github.com/openstack-k8s-operators/ci-framework/blob/main/roles/adoption_osp_deploy/tasks/prepare_overcloud.yml#L206
- https://github.com/openstack-k8s-operators/ci-framework/blob/main/roles/adoption_osp_deploy/tasks/prepare_overcloud.yml#L217
- https://github.com/openstack-k8s-operators/ci-framework/blob/main/roles/adoption_osp_deploy/tasks/prepare_overcloud.yml#L236
There was a problem hiding this comment.
Yeah, sometime ago I had a look at the Ansible internals and iirc delegate_to only works with hosts, not groups.
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lewisdenny, pablintino The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit a86d3fe
into
openstack-k8s-operators:main
For inspection we need to add the ironic-python-agent to the /var/lib/ironic/httpboot folder. Update the hook to install the package on groups - osp-controllers and osp-underclouds, and copy the file to the appropriate location.