[kustomize_deploy] Make wait conditions optional #2578
Conversation
In some ocassions, like when applying more than one nodesets the user may not want to wait for the first one to be applied and wait for all of them at once when all are applied. This change is about not forcing the user, for no reason, to run a command to wait for a condition after some `oc apply` has been done.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Thanks for the PR! ❤️ |
|
This PR is stale because it has been for over 15 days with no activity. |
|
This PR is stale because it has been for over 15 days with no activity. |
| @@ -40,7 +38,7 @@ | |||
| quiet: true | |||
| ignore_errors: true # noqa: ignore-errors | |||
| register: _builtin_wait_cond_result | |||
| loop: "{{ stage.wait_conditions }}" | |||
| loop: "{{ stage.wait_conditions | default([]) }}" | |||
There was a problem hiding this comment.
Would this execute faster if a condition was used on the block?
Instead of running each task with an empty iteration, all the tasks in the block is skipped?
In some ocassions, like when applying more than one nodesets the user may not want to wait for the first one to be applied and wait for all of them at once when all are applied.
This change is about not forcing the user, for no reason, to run a command to wait for a condition after some
oc applyhas been done.