bootc images support #484
Draft
bootc images support #484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
openshift-ci
bot
added
the
do-not-merge/work-in-progress
snir911
force-pushed
the
bootc
branch
2 times, most recently
from
169536a to
63f1b2a
Compare
openshift-merge-robot
added
the
needs-rebase
snir911
force-pushed
the
bootc
branch
4 times, most recently
from
c63d04d to
2dd10a3
Compare
bpradipt
reviewed
Dec 10, 2024
| [install.filesystem.root] | ||
| type = "ext4" | ||
| [install] | ||
| kargs = [ "console=ttyS0", "selinux=0", "enforcing=0", "audit=0"] |
There was a problem hiding this comment.
We'll need to enable selinux eventually. May be worth testing without adding the following args "selinux=0", "enforcing=0", "audit=0" ?
snir911
force-pushed
the
bootc
branch
2 times, most recently
from
f307793 to
d19caae
Compare
snir911
force-pushed
the
bootc
branch
2 times, most recently
from
33f0614 to
e28101b
Compare
openshift-merge-robot
removed
the
needs-rebase
Apply the updates suggested by `govulncheck`: - go 1.22.7 - github.com/coreos/ignition/v2@v2.14.0 Also run `go mod tidy`. Signed-off-by: Camilla Conte <cconte@redhat.com>
Signed-off-by: Camilla Conte <cconte@redhat.com>
Bumping OSC version is a bit tricky as it should happen at many locations scattered everywhere in the tree. Commit e2a4c34 introduced an `OSC_VERSION` tag to help tracking these locations. Unfortunately, `make bundle` wreaks havoc in this logic as it overwrites lines at several locations and drops the tag: - everywhere in the `bundle` directory - some locations in the base CSV - a single location in `config/manager/kustomization.yaml` As a result, we can only rely on `OSC_VERSION` for a subset of the locations that need care. The other ones are: - the `olm.skipRange` annotation in the base CSV - the `spec.version` field in the base CSV - the `spec.replaces` field in the base CSV `make bundle` should then be run to propagate the version bump to the rest of the repo. Document all that. While here set the tag for the metrics-server container that was recently added. Signed-off-by: Greg Kurz <groug@kaod.org>
It is about time to bump for the upcoming release. Fixes: https://issues.redhat.com/browse/KATA-3488 Signed-off-by: Greg Kurz <groug@kaod.org>
We need to update containers/image dependency to v5.22+ As the dependency comes from machine-config, this commit brings it to the first version that depends on containers/image 5.22 Signed-off-by: Julien Ropé <jrope@redhat.com>
Setup CoCo on baremetal OpenShift worker nodes using the layered image deployment feature of OSC operator. Signed-off-by: Pradipta Banerjee <pradipta.banerjee@gmail.com> Signed-off-by: Niteesh Dubey <niteesh@us.ibm.com> Signed-off-by: Fabiano Fidêncio <fabiano@fidencio.org>
Also rename the folder to use smallcase. Signed-off-by: Pradipta Banerjee <pradipta.banerjee@gmail.com>
Place it under cm-helpers sub-dir Signed-off-by: Pradipta Banerjee <pradipta.banerjee@gmail.com>
Remove Cameron, add Victor and Tom. Drop some trailing spaces on the way. Signed-off-by: Greg Kurz <groug@kaod.org>
Signed-off-by: Balint Tobik <btobik@redhat.com>
Rever memory overhead of `kata` to 350 megs. Commit text example : The pod overhead of peer pods is expected to be lower than regular kata pods. Use a different set of values for the `kata` and `kata-remote` runtime classe, like upstream kata does. Current numbers for `kata` are kept. New numbers for `kata-remote` are taken from upstream.The numbers can probably be refined some more through experiments. Signed-off-by: Greg Kurz <groug@kaod.org>
The return code for verify_params was not checked before invoking uninstall Signed-off-by: Pradipta Banerjee <pradipta.banerjee@gmail.com>
The current GA version is v1.8.1 Signed-off-by: Pradipta Banerjee <pradipta.banerjee@gmail.com>
For the sake of being consistent with the builder which is rhel9 already. Signed-off-by: Greg Kurz <groug@kaod.org>
- update machine-config to latest, to get dependency containers/image updated to 5.29.3 - update controller-gen to 0.16.5 for compatibility with the above - update import statements and some function calls in .go files to take into account modifications in machine-config API Signed-off-by: Julien Ropé <jrope@redhat.com>
1. Check for available nbd device and mount it rather than using hardcoded values. In case nbd does not exist, script should give proper message. 2. Add cases for handling proper log messages when incorrect HKD.crt is being used. Changes for nbd availability negative test case Signed-off-by: Gaurav Kumar <gauravku@redhat.com>
OCP/OKD developers suggested to check the image in the CluserVersion object in order to differentiate OCP and OKD. Signed-off-by: Greg Kurz <groug@kaod.org>
Not used anymore. Signed-off-by: Greg Kurz <groug@kaod.org>
Otherwise the address won't be discovered from another namespaces. Signed-off-by: Fabiano Fidêncio <fabiano@fidencio.org>
The metrics server is deployed alongside the OSC controller to collect SLI/SLO oriented metrics. It is currently assumed to be shipped in the OSC monitor image. This is suboptimal since the OSC repo doesn't build the OSC monitor image. Build it and deploy it in the same container image as the controller. This is clearer and ensures a custom operator build also has a functional metrics server. This will also avoid the e2e check in the upstream CI to fail because the OSC monitor image isn't published yet. Signed-off-by: Greg Kurz <groug@kaod.org>
Signed-off-by: Snir Sheriber <ssheribe@redhat.com>
supports URIs with the following pattern: bootc::quay.io/openshift_sandboxed_containers/azure-bootc-podvm-image:latest currently only Azure is supported, see README
see README for instructions
TODO: check deletion TODO: test aws artifact upload TODO: support libvirt TODO: check internal todos
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
openshift-merge-robot
added
the
needs-rebase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Description of the problem which is fixed/What is the use case
- What I did
- How to verify it
- Description for the changelog