Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDN-5297,SDN-5508: DownStream Merge Sync from 4.18 [12-17-2024] #2400

Closed

Conversation

jluhrsen
Copy link
Contributor

this supersedes #2349

trozet and others added 30 commits September 4, 2024 21:58
OCPBUGS-39157,SDN-4930: Downstream Merge Sept 4th
ensure that user defined networks are using ipfamilies that the cluster
supports

Signed-off-by: Jacob Tanenbaum <jtanenba@redhat.com>
currently the udn/nad primary network e2e testing does nothing to check
to state of the cluster before creating the network. This makes it
possible to test primary networks with ip families that the underlying
cluster does not support which is not possible.

This commit ensures that e2e testing will only create primary networks
that conform to the cluster being tested

Signed-off-by: Jacob Tanenbaum <jtanenba@redhat.com>
UDN LGW: ensure masq chain exists before adding rules
Signed-off-by: Enrique Llorente <ellorent@redhat.com>
adding testing using User Defined Network objects to pod2Egress testing
and "isolates overlapping CIDRs" tests

Signed-off-by: Jacob Tanenbaum <jtanenba@redhat.com>
This commit is to add some unit tests to make sure proper NAT entries
are being created i NBDB while DisableSNATMultipleGWs is set to true.

Signed-off-by: Arnab Ghosh <arnabghosh89@gmail.com>
corrections to user defined networking
Add unit tests for UDN while DS is true
Add a source pod create retry function for egress firewall e2e.
When users attach pod to a secondary network and override the default
route pod. It will cause the assymetric routing for service haripin
traffic.

We add static routes to ensure the traffic to the hairpin masquerade
IP always goes to OVN.

Signed-off-by: Peng Liu <pliu@redhat.com>
There are some expectation at the dev-env interface at metallb that can
change and break ovn-k CI, let's pin it so we can propertly consume
those changes at a PR later on.

Signed-off-by: Enrique Llorente <ellorent@redhat.com>
Test opens a TCP connection that simulates a GCP LB environment where
the packet is redirected via iptables to a local server on a node. Note,
in GCP the LB does not DNAT the VIP, so the packet arrives to the node
with the GCP VIP on it. In OCP, we then redirect that packet to the
local kapi server running on the node.

Once the test opens the TCP connection, it leaves it open for 2 minutes
while ovnkube-node is then deleted. Post ovn-controller starting it
should not flush the conntrack in zone 0, and the test ensures that the
conntrack entry still exists.

Recent OVN regression that prompted this E2E: https://issues.redhat.com/browse/FDP-773

Signed-off-by: Tim Rozet <trozet@redhat.com>
Signed-off-by: Tim Rozet <trozet@redhat.com>
Signed-off-by: Tim Rozet <trozet@redhat.com>
Adds e2e test: conntrack flush after ovnkube delete + bumps OVN with fix
When deploying the kind cluster, in order to allow running VMs with
primary-UDN, the kubevirt CR is patched with:
- NetworkBindingPlugins feature gate.
- the passt network binding

Signed-off-by: Ram Lavi <ralavi@redhat.com>
Co-authored-by: Miguel Duarte Barroso <mdbarroso@redhat.com>
Signed-off-by: Ram Lavi <ralavi@redhat.com>
Signed-off-by: Ram Lavi <ralavi@redhat.com>
Separating two different installations into different functions.
In future commit this will allow deploying kubevirt-ipam separately when
needed.

Signed-off-by: Ram Lavi <ralavi@redhat.com>
Although they usually deployed together, ipam may sometimes need to be
deployed out of band for dev purposes.
For this purpose, introducing an opt-out flag that will prevent
installing the latest ipam-controller while still installing
cert-manager.

Signed-off-by: Ram Lavi <ralavi@redhat.com>
Signed-off-by: Miguel Duarte Barroso <mdbarroso@redhat.com>
As a bonus add some coverage to the function that generates the syntetic
network selection element we use to request the primary UDN attachment.

Signed-off-by: Miguel Duarte Barroso <mdbarroso@redhat.com>
Signed-off-by: Enrique Llorente <ellorent@redhat.com>
Co-authored-by: Miguel Duarte Barroso <mdbarroso@redhat.com>
Signed-off-by: Enrique Llorente <ellorent@redhat.com>
Signed-off-by: Enrique Llorente <ellorent@redhat.com>
trozet and others added 10 commits November 11, 2024 08:44
Fix Panic in ClusterManager: Release IDs only for Primary L2 UDNs
SDN-4930: Bump OVN to ovn24.09-24.09.0-33.el9fdp
For a crash fix and CVE backports in libreswan

Signed-off-by: Zenghui Shi <zshi@redhat.com>
…rry-pick-2375-to-release-4.18

[release-4.18] OCPBUGS-45867: pin libreswan to 4.6-3.el9_0.3
…openshift-4.18-ovn-kubernetes-microshift

OCPBUGS-41284: Updating ovn-kubernetes-microshift-container image to be consistent with ART for 4.18
Signed-off-by: Zenghui Shi <zshi@redhat.com>
…rry-pick-2387-to-release-4.18

[release-4.18] OCPBUGS-45952: bump OVS version to 3.4.0-18
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Dec 18, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 18, 2024

@jluhrsen: This pull request references SDN-5297 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target either version "4.17." or "openshift-4.17.", but it targets "openshift-4.18" instead.

This pull request references SDN-5508 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.17.z" version, but no target version was set.

In response to this:

this supersedes #2349

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

openshift-ci bot commented Dec 18, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jluhrsen
Once this PR has been reviewed and has the lgtm label, please assign jcaamano for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jluhrsen
Copy link
Contributor Author

/test e2e-azure-ovn-upgrade
/test e2e-gcp-ovn-techpreview

@jluhrsen
Copy link
Contributor Author

/test e2e-metal-ipi-ovn-ipv6-techpreview
/test e2e-aws-ovn-hypershift-conformance-techpreview
/test e2e-azure-ovn-techpreview
/test e2e-metal-ipi-ovn-dualstack-techpreview
/test e2e-vsphere-ovn-techpreview
/test e2e-aws-ovn-techpreview
/test e2e-gcp-ovn-techpreview
/test e2e-metal-ipi-ovn-techpreview
/test openshift-e2e-gcp-ovn-techpreview-upgrade

@jluhrsen
Copy link
Contributor Author

/test 4.17-upgrade-from-stable-4.16-local-gateway-e2e-aws-ovn-upgrade
/test e2e-aws-ovn-local-gateway
/test e2e-aws-ovn-local-to-shared-gateway-mode-migration
/test e2e-aws-ovn-shared-to-local-gateway-mode-migration

@jluhrsen
Copy link
Contributor Author

/test e2e-aws-ovn-upgrade
/test e2e-gcp-ovn-techpreview

@jluhrsen
Copy link
Contributor Author

/payload 4.17 ci blocking
/payload 4.17 nightly blocking

Copy link
Contributor

openshift-ci bot commented Dec 19, 2024

@jluhrsen: trigger 4 job(s) of type blocking for the ci release of OCP 4.17

  • periodic-ci-openshift-release-master-ci-4.17-upgrade-from-stable-4.16-e2e-aws-ovn-upgrade
  • periodic-ci-openshift-release-master-ci-4.17-upgrade-from-stable-4.16-e2e-azure-ovn-upgrade
  • periodic-ci-openshift-release-master-ci-4.17-e2e-gcp-ovn-upgrade
  • periodic-ci-openshift-hypershift-release-4.17-periodics-e2e-aws-ovn

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/0db64230-bdc5-11ef-96ba-491e62d547a2-0

trigger 9 job(s) of type blocking for the nightly release of OCP 4.17

  • periodic-ci-openshift-release-master-nightly-4.17-e2e-aws-ovn-serial
  • periodic-ci-openshift-release-master-ci-4.17-e2e-aws-ovn-upgrade
  • periodic-ci-openshift-release-master-ci-4.17-e2e-aws-ovn-upgrade
  • periodic-ci-openshift-release-master-ci-4.17-e2e-azure-ovn-upgrade
  • periodic-ci-openshift-release-master-nightly-4.17-fips-payload-scan
  • periodic-ci-openshift-release-master-ci-4.17-upgrade-from-stable-4.16-e2e-gcp-ovn-rt-upgrade
  • periodic-ci-openshift-hypershift-release-4.17-periodics-e2e-aws-ovn-conformance
  • periodic-ci-openshift-release-master-nightly-4.17-e2e-metal-ipi-ovn-bm
  • periodic-ci-openshift-release-master-nightly-4.17-e2e-metal-ipi-ovn-ipv6

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/0db64230-bdc5-11ef-96ba-491e62d547a2-1

@jluhrsen
Copy link
Contributor Author

/retest

@jluhrsen
Copy link
Contributor Author

@jluhrsen: trigger 4 job(s) of type blocking for the ci release of OCP 4.17

  • periodic-ci-openshift-release-master-ci-4.17-upgrade-from-stable-4.16-e2e-aws-ovn-upgrade
  • periodic-ci-openshift-release-master-ci-4.17-upgrade-from-stable-4.16-e2e-azure-ovn-upgrade
  • periodic-ci-openshift-release-master-ci-4.17-e2e-gcp-ovn-upgrade
  • periodic-ci-openshift-hypershift-release-4.17-periodics-e2e-aws-ovn

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/0db64230-bdc5-11ef-96ba-491e62d547a2-0

trigger 9 job(s) of type blocking for the nightly release of OCP 4.17

  • periodic-ci-openshift-release-master-nightly-4.17-e2e-aws-ovn-serial
  • periodic-ci-openshift-release-master-ci-4.17-e2e-aws-ovn-upgrade
  • periodic-ci-openshift-release-master-ci-4.17-e2e-aws-ovn-upgrade
  • periodic-ci-openshift-release-master-ci-4.17-e2e-azure-ovn-upgrade
  • periodic-ci-openshift-release-master-nightly-4.17-fips-payload-scan
  • periodic-ci-openshift-release-master-ci-4.17-upgrade-from-stable-4.16-e2e-gcp-ovn-rt-upgrade
  • periodic-ci-openshift-hypershift-release-4.17-periodics-e2e-aws-ovn-conformance
  • periodic-ci-openshift-release-master-nightly-4.17-e2e-metal-ipi-ovn-bm
  • periodic-ci-openshift-release-master-nightly-4.17-e2e-metal-ipi-ovn-ipv6

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/0db64230-bdc5-11ef-96ba-491e62d547a2-1

These look ok. the ci jobs all passed.

the nightly jobs had a couple of failures.

nightly-4.17-e2e-aws-ovn-serial failed with something about KubeAPIErrorBudgetBurn. the job seems pretty healthy in general, but the last time it failed in a periodic was for the same issue. not sure we want to worry about this.

e2e-azure-ovn-upgrade had a failure I don't know about in [sig-api-machinery] ValidatingAdmissionPolicy [Privileged:ClusterAdmin] should type check a CRD but looks like it fails across many jobs and doesn't seem related to anything in this work.

fips-payload-scan failed and I have no real idea on this one. asking in slack here.

Copy link
Contributor

openshift-ci bot commented Dec 20, 2024

@jluhrsen: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-upgrade 9613b46 link true /test e2e-aws-ovn-upgrade
ci/prow/e2e-metal-ipi-ovn-techpreview 9613b46 link false /test e2e-metal-ipi-ovn-techpreview
ci/prow/e2e-azure-ovn-techpreview 9613b46 link false /test e2e-azure-ovn-techpreview
ci/prow/e2e-metal-ipi-ovn-dualstack-techpreview 9613b46 link false /test e2e-metal-ipi-ovn-dualstack-techpreview
ci/prow/security 9613b46 link false /test security
ci/prow/openshift-e2e-gcp-ovn-techpreview-upgrade 9613b46 link false /test openshift-e2e-gcp-ovn-techpreview-upgrade
ci/prow/e2e-aws-ovn-techpreview 9613b46 link false /test e2e-aws-ovn-techpreview
ci/prow/e2e-gcp-ovn-techpreview 9613b46 link true /test e2e-gcp-ovn-techpreview
ci/prow/e2e-aws-ovn-kubevirt 9613b46 link false /test e2e-aws-ovn-kubevirt
ci/prow/e2e-vsphere-ovn-techpreview 9613b46 link false /test e2e-vsphere-ovn-techpreview
ci/prow/e2e-aws-ovn-hypershift-conformance-techpreview 9613b46 link false /test e2e-aws-ovn-hypershift-conformance-techpreview
ci/prow/e2e-metal-ipi-ovn-ipv6-techpreview 9613b46 link false /test e2e-metal-ipi-ovn-ipv6-techpreview

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 26, 2024
@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jluhrsen
Copy link
Contributor Author

jluhrsen commented Jan 7, 2025

Looks like something got merged in to 4.17 outside of this sync process. will have to rebase and figure it out.

@jluhrsen
Copy link
Contributor Author

jluhrsen commented Jan 7, 2025

it may be easier to just use a new PR with the latest from 4.18. These conflicts are pretty confusing to fix after doing a 'git merge'

closing for now and we'll see how the new PR does.

@jluhrsen jluhrsen closed this Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Development

Successfully merging this pull request may close these issues.