Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.15] OCPBUGS-43605: Add SDN node subnet gateway IP to host-network address_set #2353

Open
wants to merge 1 commit into
base: release-4.15
Choose a base branch
from
Open

[release-4.15] OCPBUGS-43605: Add SDN node subnet gateway IP to host-network address_set #2353

wants to merge 1 commit into from
+190 −6

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #2328

/assign pliurh

@pliurh
Add SDN node subnet gateway IP to host-network address_set
1d29d97 
During live SDN migration, host-to-pod traffic originating from
SDN nodes will use the first IP address of the hybrid overlay node
subnet. These IPs are being added to ensure proper functionality of
host network policies.

Signed-off-by: Peng Liu <pliu@redhat.com>
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Nov 15, 2024
Merged
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: Detected clone of Jira Issue OCPBUGS-43344 with correct target version. Will retitle the PR to link to the clone.
/retitle [release-4.15] OCPBUGS-43769: Add SDN node subnet gateway IP to host-network address_set

In response to this:

This is an automated cherry-pick of #2328

/assign pliurh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot changed the title [release-4.15] OCPBUGS-43344: Add SDN node subnet gateway IP to host-network address_set [release-4.15] OCPBUGS-43769: Add SDN node subnet gateway IP to host-network address_set Nov 15, 2024
@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Nov 15, 2024
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-43769, which is invalid:

  • expected the bug to be open, but it isn't
  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is Closed (Done) instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #2328

/assign pliurh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Nov 15, 2024
@openshift-ci openshift-ci bot requested review from abhat and tssurya November 15, 2024 02:57
@pliurh
Copy link
Contributor

pliurh commented Nov 15, 2024

/retitle [release-4.15] OCPBUGS-43605: Add SDN node subnet gateway IP to host-network address_set

@openshift-ci openshift-ci bot changed the title [release-4.15] OCPBUGS-43769: Add SDN node subnet gateway IP to host-network address_set [release-4.15] OCPBUGS-43605: Add SDN node subnet gateway IP to host-network address_set Nov 15, 2024
@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Nov 15, 2024
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-43605, which is valid.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.z) matches configured target version for branch (4.15.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-43344 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-43344 targets the "4.16.z" version, which is one of the valid target versions: 4.16.0, 4.16.z
  • bug has dependents

Requesting review from QA contact:
/cc @anuragthehatter

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #2328

/assign pliurh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@pliurh
Copy link
Contributor

pliurh commented Nov 19, 2024 •
edited
Loading

/cc @trozet PTAL

@openshift-ci openshift-ci bot requested a review from danwinship November 19, 2024 02:16
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 19, 2024

@pliurh: GitHub didn't allow me to request PR reviews from the following users: PTAL.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @danwinship PTAL

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@pliurh
Copy link
Contributor

pliurh commented Dec 11, 2024

/cc @trozet

PTAL

@openshift-ci openshift-ci bot requested a review from trozet December 11, 2024 07:25
@openshift-ci-robot openshift-ci-robot mentioned this pull request Dec 11, 2024
Merged
@zhaozhanqi
Copy link

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Dec 12, 2024
trozet
trozet approved these changes Dec 12, 2024
View reviewed changes
Copy link
Contributor

@trozet trozet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Dec 12, 2024
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 9c4d301 and 1 for PR HEAD 1d29d97 in total

@pliurh
Copy link
Contributor

pliurh commented Dec 16, 2024

/retest-required

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 9c4d301 and 2 for PR HEAD 1d29d97 in total

23 similar comments
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 9c4d301 and 2 for PR HEAD 1d29d97 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 9c4d301 and 2 for PR HEAD 1d29d97 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 9c4d301 and 2 for PR HEAD 1d29d97 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 9c4d301 and 2 for PR HEAD 1d29d97 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 9c4d301 and 2 for PR HEAD 1d29d97 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 9c4d301 and 2 for PR HEAD 1d29d97 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 9c4d301 and 2 for PR HEAD 1d29d97 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 9c4d301 and 2 for PR HEAD 1d29d97 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 9c4d301 and 2 for PR HEAD 1d29d97 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 9c4d301 and 2 for PR HEAD 1d29d97 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 9c4d301 and 2 for PR HEAD 1d29d97 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 9c4d301 and 2 for PR HEAD 1d29d97 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 9c4d301 and 2 for PR HEAD 1d29d97 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 9c4d301 and 2 for PR HEAD 1d29d97 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 9c4d301 and 2 for PR HEAD 1d29d97 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 9c4d301 and 2 for PR HEAD 1d29d97 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 9c4d301 and 2 for PR HEAD 1d29d97 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 9c4d301 and 2 for PR HEAD 1d29d97 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 9c4d301 and 2 for PR HEAD 1d29d97 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 9c4d301 and 2 for PR HEAD 1d29d97 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 9c4d301 and 2 for PR HEAD 1d29d97 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 9c4d301 and 2 for PR HEAD 1d29d97 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 9c4d301 and 2 for PR HEAD 1d29d97 in total

@pliurh
Copy link
Contributor

pliurh commented Jan 13, 2025

/retest-required

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD daaf1b8 and 2 for PR HEAD 1d29d97 in total

1 similar comment
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD daaf1b8 and 2 for PR HEAD 1d29d97 in total

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 13, 2025

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-kubevirt 1d29d97 link false /test e2e-aws-ovn-kubevirt
ci/prow/e2e-ovn-hybrid-step-registry 1d29d97 link false /test e2e-ovn-hybrid-step-registry
ci/prow/e2e-openstack-ovn 1d29d97 link false /test e2e-openstack-ovn
ci/prow/e2e-azure-ovn 1d29d97 link false /test e2e-azure-ovn
ci/prow/e2e-vsphere-ovn 1d29d97 link false /test e2e-vsphere-ovn
ci/prow/security 1d29d97 link false /test security
ci/prow/e2e-aws-live-migration-sdn-ovn-rollback 1d29d97 link false /test e2e-aws-live-migration-sdn-ovn-rollback
ci/prow/e2e-aws-ovn-hypershift 1d29d97 link true /test e2e-aws-ovn-hypershift
ci/prow/e2e-aws-ovn-upgrade-local-gateway 1d29d97 link true /test e2e-aws-ovn-upgrade-local-gateway
ci/prow/e2e-aws-ovn-upgrade 1d29d97 link true /test e2e-aws-ovn-upgrade
ci/prow/e2e-aws-ovn-windows 1d29d97 link true /test e2e-aws-ovn-windows
ci/prow/4.15-upgrade-from-stable-4.14-e2e-aws-ovn-upgrade 1d29d97 link true /test 4.15-upgrade-from-stable-4.14-e2e-aws-ovn-upgrade
ci/prow/e2e-aws-live-migration-sdn-ovn 1d29d97 link true /test e2e-aws-live-migration-sdn-ovn
ci/prow/e2e-aws-ovn-local-to-shared-gateway-mode-migration 1d29d97 link true /test e2e-aws-ovn-local-to-shared-gateway-mode-migration
ci/prow/4.15-upgrade-from-stable-4.14-local-gateway-images 1d29d97 link true /test 4.15-upgrade-from-stable-4.14-local-gateway-images
ci/prow/e2e-metal-ipi-ovn-ipv6 1d29d97 link true /test e2e-metal-ipi-ovn-ipv6
ci/prow/4.15-upgrade-from-stable-4.14-local-gateway-e2e-aws-ovn-upgrade 1d29d97 link true /test 4.15-upgrade-from-stable-4.14-local-gateway-e2e-aws-ovn-upgrade
ci/prow/e2e-aws-ovn-shared-to-local-gateway-mode-migration 1d29d97 link true /test e2e-aws-ovn-shared-to-local-gateway-mode-migration
ci/prow/e2e-metal-ipi-ovn-dualstack 1d29d97 link true /test e2e-metal-ipi-ovn-dualstack
ci/prow/e2e-aws-ovn-local-gateway 1d29d97 link true /test e2e-aws-ovn-local-gateway
ci/prow/4.15-upgrade-from-stable-4.14-e2e-gcp-ovn-rt-upgrade 1d29d97 link true /test 4.15-upgrade-from-stable-4.14-e2e-gcp-ovn-rt-upgrade
ci/prow/4.15-upgrade-from-stable-4.14-images 1d29d97 link true /test 4.15-upgrade-from-stable-4.14-images
ci/prow/e2e-aws-ovn-serial 1d29d97 link true /test e2e-aws-ovn-serial
ci/prow/images 1d29d97 link true /test images
ci/prow/e2e-gcp-ovn 1d29d97 link true /test e2e-gcp-ovn
ci/prow/e2e-aws-ovn 1d29d97 link true /test e2e-aws-ovn
ci/prow/unit 1d29d97 link true /test unit
ci/prow/e2e-azure-ovn-upgrade 1d29d97 link true /test e2e-azure-ovn-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trozet trozet trozet approved these changes

@abhat abhat Awaiting requested review from abhat

@tssurya tssurya Awaiting requested review from tssurya

@anuragthehatter anuragthehatter Awaiting requested review from anuragthehatter

@danwinship danwinship Awaiting requested review from danwinship

Assignees

@mffiedler mffiedler

@rbbratta rbbratta

@weliang1 weliang1

@pliurh pliurh

@anuragthehatter anuragthehatter

@huiran0826 huiran0826

@asood-rh asood-rh

@jechen0648 jechen0648

@yingwang-0320 yingwang-0320

@qiowang721 qiowang721

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.