[DNM/QE only] EIP for layer 3 and layer 2 UDN #2333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
do-not-merge/hold
|
@martinkennelly: GitHub didn't allow me to request PR reviews from the following users: martinkennelly. Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@jechen0648 cc |
openshift-merge-robot
added
the
needs-rebase
martinkennelly
force-pushed
the
eip-ds-test
branch
from
56ed493 to
3464456
Compare
openshift-merge-robot
removed
the
needs-rebase
|
/retest |
1 similar comment
|
/retest |
martinkennelly
force-pushed
the
eip-ds-test
branch
from
3464456 to
a678c4f
Compare
|
/test |
|
@jtaleric: The
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test |
|
@jtaleric: No presubmit jobs available for openshift/ovn-kubernetes@master In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/tests |
martinkennelly
force-pushed
the
eip-ds-test
branch
from
a678c4f to
ea86d0a
Compare
|
/retest |
|
/test qe-perfscale-aws-ovn-small-udn-density-l3 |
|
Tech preview is failing with CLBO for ovn-k - something is up there with my latest ds merge here. I will check tomorrow. I did my usual check building a kind cluster. |
martinkennelly
force-pushed
the
eip-ds-test
branch
from
6bb2b67 to
3464456
Compare
|
Needed to disable UDN host isolation. |
martinkennelly
force-pushed
the
eip-ds-test
branch
from
3464456 to
0ec3535
Compare
|
/test qe-perfscale-aws-ovn-small-udn-density-l3 |
1 similar comment
|
/test qe-perfscale-aws-ovn-small-udn-density-l3 |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: martinkennelly The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test |
|
@jtaleric: The The following commands are available to trigger optional jobs: Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test qe-perfscale-aws-ovn-small-udn-density-l3 |
martinkennelly
force-pushed
the
eip-ds-test
branch
from
2c9ca3b to
b3cb9ec
Compare
martinkennelly
changed the title
martinkennelly
force-pushed
the
eip-ds-test
branch
from
b3cb9ec to
8efce9b
Compare
…twork exist test Signed-off-by: Or Mergi <ormergi@redhat.com>
On CUDN cleanup is inconsistent as we see some flaky tests due to CUDN "already exist" errors, implying object are not actually deleted. Wait for CUDN object be gone when deleted Signed-off-by: Or Mergi <ormergi@redhat.com>
CUDN is cluster-scoped object, in case tests running in parallel, having random names avoids conflicting with other tests. Use random metadata.name for CUDN objects. The "isolates overlapping CIDRs" tests create objects based on the 'red' and 'blue' variables, including CUDN objects. Change the tests CUDN creation use random names and update the given 'networkAttachmentConfigParams' with the new generated name. Update 'red' & 'blue' vaiables with the generated name, carried by 'networkAttachmentConfigParams' (netConfig.name). The pod2Egress tests asserts on the CUDN object name given by 'userDefinedNetworkName'. In practice the tests netConfigParam.name is userDefinedNetworkName. Change the assertion to check the given netConfigParam. Signed-off-by: Or Mergi <ormergi@redhat.com>
Signed-off-by: nithyar <nithyar@nvidia.com>
Signed-off-by: nithyar <nithyar@nvidia.com>
e2e, CUDN: Improve stability
Reconcile RouteAdvertisements in cluster manager
Add missing enum validation for RouteAdvertisements
The NetPol test checks assigned pod IP only against IPv4 subnet which would fail on IPv6 only cluster. This commit fixes it by checking on all valid CIDRs. Signed-off-by: Periyasamy Palanisamy <pepalani@redhat.com>
As of today the NetworkReady condition indicated a NAD has been created. And not necessarily that the underlying network is ready to work with, because it require other internal components to act (e.g.: set ovs ports, ovn flows, etc..). Rename the NetworkReady condition type to NetworkCreated so it describe better what it indicates. This change enable introducing alternative "NetworkReady" condition that provider actual indication a UDN network is ready, and that other internal component acted successfully. Signed-off-by: Or Mergi <ormergi@redhat.com>
The variable ginkgo_focus is misspelled as gingko_focus. As the latter var is not used anywhere else in this repo and is used to concatenate the var ginkgo_focus in the next line to ginkgoargs it seems to be a typo. Fixes: #4942 Signed-off-by: Felix Schumacher <felix.schumacher@internetallee.de>
This commit adds a new controller to import BGP learnt routes into OVN. The controller runs in ovnkube-controller so it only supports IC architecture where ovnkube-controller has kernel access on each node. Networks should register to this controller to have routes imported for them. Routes are imported into the network's gateway router. Multipath routes are supported. The controller subscribes for netlink route events. When a route is updated, the corresponding network is queued to be sync'ed. A network is also sync'ed when registered to the controller. Synchronizations are delayed by a small amount of time to prevent a series of consecutive route updates so synchornize the same network twice. Synchronizations apply the difference between current and desired state. The controller subscribes to netlink link events to learn the routing table associated to a network vrf. The network is inferred from the vrf device name. When learning the routing table, the corresponding network is queued to be sync'ed. Signed-off-by: Jaime Caamaño Ruiz <jcaamano@redhat.com>
Signed-off-by: Jaime Caamaño Ruiz <jcaamano@redhat.com>
Signed-off-by: Periyasamy Palanisamy <pepalani@redhat.com>
Signed-off-by: Periyasamy Palanisamy <pepalani@redhat.com>
Fix subnet check for assigned pod IPs
go-controller: fix typo in test script
Import learnt BGP routes into OVN
UDN: Rename NetworkReady condition to NetworkCreated
When multinetwork policies support is disabled WatchNamespaces should run to completion for primary UDNs. This was not happening because a primary UDN is also a secondary network. Signed-off-by: Patryk Diak <pdiak@redhat.com>
Fix WatchNamespaces for UDNs
It was adding multiple incorrect rules for the same endpoint and validating that they all got removed, but that won't work with the nftables port where it will use a map, making it impossible to have multiple rules for the same endpoint. Add another egress service to the mix, with a different endpoint, so there are enough unique endpoints for all the test cases. Signed-off-by: Dan Winship <danwinship@redhat.com>
Signed-off-by: Dan Winship <danwinship@redhat.com>
Enhance the script to use the updated OVN Kubernetes organization. Add options to easily toggle building the Docker image and deploying with or without OVN Interconnect when setting up the kind cluster. Signed-off-by: Flavio Fernandes <ffernandes@nvidia.com>
Also, use commit ovn-kubernetes/kubernetes-traffic-flow-tests@3e092f2 Signed-off-by: Flavio Fernandes <ffernandes@nvidia.com>
martinkennelly
force-pushed
the
eip-ds-test
branch
from
8efce9b to
84648c4
Compare
When making a call to netlink to retrieve a links addresses, netlink will return the addresses and group them by at least the addresses scope. It will return addresses grouped by scope - host, link and global scope. Therefore if the EIP address assigned to the ext bridge to support EIP for UDN is scope host, and OVN Kube restarts, it may select the EIP address as the primary IP address. Signed-off-by: Martin Kennelly <mkennell@redhat.com>
|
/retest |
|
@martinkennelly: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/hold
/cc