Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add scripts to create iso using bootc-image-builder #4387

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

praveenkumar
Copy link
Contributor

Which issue(s) this PR addresses:

Closes #

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 7, 2025
Copy link
Contributor

openshift-ci bot commented Jan 7, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link
Contributor

openshift-ci bot commented Jan 7, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: praveenkumar
Once this PR has been reviewed and has the lgtm label, please assign pacevedom for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ggiguash
Copy link
Contributor

ggiguash commented Jan 7, 2025

@praveenkumar ,
I'm not sure we want to support these scripts in the dev repository. I believe, we should instead update the https://github.com/openshift/microshift/blob/main/docs/contributor/image_mode.md documentation and refer users to it when necessary.

@praveenkumar
Copy link
Contributor Author

praveenkumar commented Jan 7, 2025

@praveenkumar , I'm not sure we want to support these scripts in the dev repository. I believe, we should instead update the https://github.com/openshift/microshift/blob/main/docs/contributor/image_mode.md documentation and refer users to it when necessary.

@ggiguash you mean those script should be part of docs/config instead as part of scripts directory? I kind of have a hidden agenda around those scripts to be part of microshift (location doesn't matter) to consume directly it to my other project (like cloning it and execute). BTW we can even have e2e test for BIB + deploying final iso/qcow2 generated using those if this we want in future or is it already tested somewhere else?

@ggiguash
Copy link
Contributor

ggiguash commented Jan 8, 2025

you mean those script should be part of docs/config instead as part of scripts directory?

Such scripts are intended for devenv setup and we have previous experience with build.sh I would not want to repeat. Users took it as a base for their procedures, but it was very contextual and not correct for all the cases.

For what I'd like to see is an augmentation of the image_mode.md page with this w/f, using the same style - instructions rather than a full script.

@praveenkumar
Copy link
Contributor Author

you mean those script should be part of docs/config instead as part of scripts directory?

Such scripts are intended for devenv setup and we have previous experience with build.sh I would not want to repeat. Users took it as a base for their procedures, but it was very contextual and not correct for all the cases.

For what I'd like to see is an augmentation of the image_mode.md page with this w/f, using the same style - instructions rather than a full script.

@ggiguash Understood, will move the script to our project and update the image mode doc with BIB info in this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants