Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-44889: Allow external configuration of download host for production builds #46

Merged
merged 1 commit into from
Dec 12, 2024
Merged

OCPBUGS-44889: Allow external configuration of download host for production builds #46

merged 1 commit into from
Dec 12, 2024

Conversation

joepvd
Copy link
Contributor

@joepvd joepvd commented Nov 22, 2024 •
edited
Loading

Would need to go in tandem with openshift-eng/ocp-build-data#5724

@openshift-ci openshift-ci bot requested review from cgwalters and dtantsur November 22, 2024 11:38
@joepvd
Copy link
Contributor Author

joepvd commented Nov 22, 2024

/retitle OCPBUGS-44889: Allow external configuration of download host for production builds

@openshift-ci openshift-ci bot changed the title Allow external configuration of download host for production builds OCPBUGS-44889: Allow external configuration of download host for production builds Nov 22, 2024
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Nov 22, 2024
@openshift-ci-robot
Copy link

@joepvd: This pull request references Jira Issue OCPBUGS-44889, which is invalid:

  • expected the bug to target either version "4.18." or "openshift-4.18.", but it targets "4.19.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@joepvd
Copy link
Contributor Author

joepvd commented Nov 22, 2024

/hold
to become konflux ready, it is better to inject url and shasum at rebase time.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 22, 2024
dtantsur
dtantsur reviewed Nov 27, 2024
View reviewed changes
Dockerfile Outdated
@@ -1,6 +1,7 @@
FROM registry.ci.openshift.org/ocp/4.18:installer AS builder

ARG DIRECT_DOWNLOAD=false
ENV ISO_HOST=https://example.com
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cannot you default ISO_HOST to the same value for now to make the change mergeable?

@elfosardo
Copy link
Contributor

/override ci/prow/okd-images

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Dec 6, 2024

@elfosardo: Overrode contexts on behalf of elfosardo: ci/prow/okd-images

In response to this:

/override ci/prow/okd-images

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@elfosardo
Copy link
Contributor

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 6, 2024
@elfosardo
Copy link
Contributor

/jira refresh

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Dec 6, 2024
@elfosardo
Copy link
Contributor

/approve

@openshift-ci-robot
Copy link

@elfosardo: This pull request references Jira Issue OCPBUGS-44889, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @jadhaj

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Dec 6, 2024
@openshift-ci openshift-ci bot requested a review from jadhaj December 6, 2024 08:49
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Dec 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elfosardo, joepvd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 6, 2024
@hroyrh
Copy link

hroyrh commented Dec 10, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 10, 2024
@honza
Copy link
Member

honza commented Dec 10, 2024

/label acknowledge-critical-fixes-only

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD f7ba768 and 2 for PR HEAD 8feddbf in total

@elfosardo
Copy link
Contributor

/override ci/prow/okd-images

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Dec 11, 2024

@elfosardo: Overrode contexts on behalf of elfosardo: ci/prow/okd-images

In response to this:

/override ci/prow/okd-images

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@elfosardo
Copy link
Contributor

/retest

1 similar comment
@elfosardo
Copy link
Contributor

/retest

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD b0108ef and 1 for PR HEAD 8feddbf in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD b0108ef and 2 for PR HEAD 8feddbf in total

2 similar comments
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD b0108ef and 2 for PR HEAD 8feddbf in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD b0108ef and 2 for PR HEAD 8feddbf in total

@elfosardo
Copy link
Contributor

/override ci/prow/okd-images

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Dec 12, 2024

@elfosardo: Overrode contexts on behalf of elfosardo: ci/prow/okd-images

In response to this:

/override ci/prow/okd-images

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Dec 12, 2024

@joepvd: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 5122770 into openshift:main Dec 12, 2024
7 checks passed
@openshift-ci-robot
Copy link

@joepvd: Jira Issue OCPBUGS-44889: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-44889 has not been moved to the MODIFIED state.

In response to this:

Would need to go in tandem with openshift-eng/ocp-build-data#5724

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: ose-machine-os-images
This PR has been included in build ose-machine-os-images-container-v4.19.0-202412121641.p0.g5122770.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtantsur dtantsur dtantsur left review comments

@cgwalters cgwalters Awaiting requested review from cgwalters

@jadhaj jadhaj Awaiting requested review from jadhaj

Assignees

@hroyrh hroyrh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@joepvd @openshift-ci-robot @elfosardo @hroyrh @honza @openshift-bot @dtantsur