Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: hcco: handle post-install creation of OIDC client secrets #5351

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

WIP: hcco: handle post-install creation of OIDC client secrets #5351

wants to merge 1 commit into from

Conversation

sjenning
Copy link
Contributor

@sjenning sjenning commented Jan 7, 2025

Avoid error when allowing guest cluster admin to provide OIDC clientSecrets post-install

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 7, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/needs-area area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release labels Jan 7, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 7, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sjenning

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed do-not-merge/needs-area labels Jan 7, 2025
@sjenning sjenning force-pushed the hcco-empty-client-secret branch from 5f08011 to 53d7e2c Compare January 7, 2025 22:03
@sjenning sjenning changed the title WIP: hcco: allow empty clientSecret in oidcClients WIP: hcco: handle post-install creation of OIDC client secrets Jan 7, 2025
@sjenning sjenning force-pushed the hcco-empty-client-secret branch from 53d7e2c to 57430cf Compare January 7, 2025 22:05
@sjenning sjenning force-pushed the hcco-empty-client-secret branch from 57430cf to 743daa4 Compare January 7, 2025 22:08
@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sjenning @openshift-merge-robot