Skip to content

Commit

Permalink
Merge pull request #5276 from jparrill/OCPBUGS-46342
Browse files Browse the repository at this point in the history
OCPBUGS-46342: Allow ARM64 arch deployment on Agent platform
  • Loading branch information
openshift-merge-bot[bot] authored Dec 12, 2024
2 parents c5e01a9 + 55c5e71 commit 2610e5c
Show file tree
Hide file tree
Showing 7 changed files with 17 additions and 7 deletions.
2 changes: 1 addition & 1 deletion api/hypershift/v1beta1/nodepool_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ type NodePool struct {

// NodePoolSpec is the desired behavior of a NodePool.
// +kubebuilder:validation:XValidation:rule="!has(oldSelf.arch) || has(self.arch)", message="Arch is required once set"
// +kubebuilder:validation:XValidation:rule="self.arch != 'arm64' || has(self.platform.aws) || has(self.platform.azure)", message="Setting Arch to arm64 is only supported for AWS and Azure"
// +kubebuilder:validation:XValidation:rule="self.arch != 'arm64' || has(self.platform.aws) || has(self.platform.azure) || has(self.platform.agent)", message="Setting Arch to arm64 is only supported for AWS, Azure and Agent"
// +kubebuilder:validation:XValidation:rule="!has(self.replicas) || !has(self.autoScaling)", message="Both replicas or autoScaling should not be set"
type NodePoolSpec struct {
// clusterName is the name of the HostedCluster this NodePool belongs to.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1310,8 +1310,10 @@ spec:
x-kubernetes-validations:
- message: Arch is required once set
rule: '!has(oldSelf.arch) || has(self.arch)'
- message: Setting Arch to arm64 is only supported for AWS and Azure
- message: Setting Arch to arm64 is only supported for AWS, Azure and
Agent
rule: self.arch != 'arm64' || has(self.platform.aws) || has(self.platform.azure)
|| has(self.platform.agent)
- message: Both replicas or autoScaling should not be set
rule: '!has(self.replicas) || !has(self.autoScaling)'
status:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1477,8 +1477,10 @@ spec:
x-kubernetes-validations:
- message: Arch is required once set
rule: '!has(oldSelf.arch) || has(self.arch)'
- message: Setting Arch to arm64 is only supported for AWS and Azure
- message: Setting Arch to arm64 is only supported for AWS, Azure and
Agent
rule: self.arch != 'arm64' || has(self.platform.aws) || has(self.platform.azure)
|| has(self.platform.agent)
- message: Both replicas or autoScaling should not be set
rule: '!has(self.replicas) || !has(self.autoScaling)'
status:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1480,8 +1480,10 @@ spec:
x-kubernetes-validations:
- message: Arch is required once set
rule: '!has(oldSelf.arch) || has(self.arch)'
- message: Setting Arch to arm64 is only supported for AWS and Azure
- message: Setting Arch to arm64 is only supported for AWS, Azure and
Agent
rule: self.arch != 'arm64' || has(self.platform.aws) || has(self.platform.azure)
|| has(self.platform.agent)
- message: Both replicas or autoScaling should not be set
rule: '!has(self.replicas) || !has(self.autoScaling)'
status:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1313,8 +1313,10 @@ spec:
x-kubernetes-validations:
- message: Arch is required once set
rule: '!has(oldSelf.arch) || has(self.arch)'
- message: Setting Arch to arm64 is only supported for AWS and Azure
- message: Setting Arch to arm64 is only supported for AWS, Azure and
Agent
rule: self.arch != 'arm64' || has(self.platform.aws) || has(self.platform.azure)
|| has(self.platform.agent)
- message: Both replicas or autoScaling should not be set
rule: '!has(self.replicas) || !has(self.autoScaling)'
status:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1480,8 +1480,10 @@ spec:
x-kubernetes-validations:
- message: Arch is required once set
rule: '!has(oldSelf.arch) || has(self.arch)'
- message: Setting Arch to arm64 is only supported for AWS and Azure
- message: Setting Arch to arm64 is only supported for AWS, Azure and
Agent
rule: self.arch != 'arm64' || has(self.platform.aws) || has(self.platform.azure)
|| has(self.platform.agent)
- message: Both replicas or autoScaling should not be set
rule: '!has(self.replicas) || !has(self.autoScaling)'
status:
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 2610e5c

Please sign in to comment.