Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Installer Dual Stack Enhancement #1731

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Installer Dual Stack Enhancement #1731

wants to merge 1 commit into from

Conversation

barbacbd
Copy link

@barbacbd barbacbd commented Jan 3, 2025

The dual stack enablement enhancement for:

  • AWS
  • GCP
  • Azure

The feature proposes changes to the:

  • cluster api providers
  • Openshift API
  • Openshift Installer

@openshift-ci openshift-ci bot requested review from syed and TrilokGeer January 3, 2025 19:12
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 3, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign patrickdillon for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@barbacbd
Copy link
Author

barbacbd commented Jan 3, 2025

/cc @sadasu
/cc @JoelSpeed
/cc @patrickdillon
/cc @jhixson74

@barbacbd
The dual stack enablement enhancement for:
8e4e270 
- AWS
- GCP
- Azure

The feature proposes changes to the:

- cluster api providers
- Openshift API
- Openshift Installer
@barbacbd barbacbd force-pushed the installer_dual_stack_enablement branch from 5b62c12 to 8e4e270 Compare January 6, 2025 14:39
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 6, 2025

@barbacbd: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@syed syed Awaiting requested review from syed

@TrilokGeer TrilokGeer Awaiting requested review from TrilokGeer

@jhixson74 jhixson74 Awaiting requested review from jhixson74

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

@patrickdillon patrickdillon Awaiting requested review from patrickdillon

@sadasu sadasu Awaiting requested review from sadasu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@barbacbd