Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ART-11252] add insights-runtime-exporter #5640

Merged
merged 1 commit into from
Nov 13, 2024
Merged

[ART-11252] add insights-runtime-exporter #5640

merged 1 commit into from
Nov 13, 2024

Conversation

mbiarnes
Copy link
Contributor

@mbiarnes mbiarnes commented Nov 8, 2024

rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED

@mbiarnes
Copy link
Contributor Author

mbiarnes commented Nov 8, 2024

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 8, 2024
@mbiarnes mbiarnes changed the title ART-11252 add insight-runtime-exporter [ART-11252] add insights-runtime-exporter Nov 8, 2024
@mbiarnes
Copy link
Contributor Author

mbiarnes commented Nov 8, 2024

/cherry-pick openshift-4.19

@openshift-cherrypick-robot
Copy link

@mbiarnes: once the present PR merges, I will cherry-pick it on top of openshift-4.19 in a new PR and assign it to you.

In response to this:

/cherry-pick openshift-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mbiarnes
Copy link
Contributor Author

mbiarnes commented Nov 8, 2024

ART-11252

@mbiarnes mbiarnes force-pushed the insights-runtime-exporter-4.18 branch from 9c8bc4a to 762ff03 Compare November 8, 2024 15:04
@mbiarnes
ART-11252 add insight-runtime-exporter
d3e275c 
rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED
@mbiarnes mbiarnes force-pushed the insights-runtime-exporter-4.18 branch from 762ff03 to d3e275c Compare November 11, 2024 12:34
@mbiarnes
Copy link
Contributor Author

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 11, 2024
@mbiarnes mbiarnes requested a review from joepvd November 11, 2024 12:35
@mbiarnes
Copy link
Contributor Author

brew test build for ose-insights-riuntime-exporter:
https://brewweb.engineering.redhat.com/brew/buildinfo?buildID=3385975

@joepvd
Copy link
Contributor

joepvd commented Nov 11, 2024

/lgtm
yet:
/hold

want to get tiigs of merges right :)

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 11, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 11, 2024
@joepvd
Copy link
Contributor

joepvd commented Nov 13, 2024

/unhold
/approve

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 13, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: joepvd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 13, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 0dd6eb5 into openshift-eng:openshift-4.18 Nov 13, 2024
2 checks passed
@openshift-cherrypick-robot
Copy link

@mbiarnes: new pull request created: #5664

In response to this:

/cherry-pick openshift-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Nov 13, 2024
Merged
@mbiarnes mbiarnes deleted the insights-runtime-exporter-4.18 branch November 19, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joepvd joepvd Awaiting requested review from joepvd

Assignees

@joepvd joepvd

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mbiarnes @openshift-cherrypick-robot @joepvd