Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove caching of legacy manila CSI dir #5624

Conversation

MaysaMacedo
Copy link

@MaysaMacedo MaysaMacedo commented Nov 6, 2024

Manila was just integrated to csi-operator. Let's update the build.
openshift/csi-operator#288

The legacy folder is being removed in this PR openshift/csi-operator#317

@MaysaMacedo
Copy link
Author

/assign @joepvd

@EmilienM
Copy link

EmilienM commented Nov 6, 2024

/lgtm

Copy link
Contributor

openshift-ci bot commented Nov 6, 2024

@EmilienM: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@joepvd
Copy link
Contributor

joepvd commented Nov 7, 2024

/cherrypick openshift-4.19

@openshift-cherrypick-robot

@joepvd: once the present PR merges, I will cherry-pick it on top of openshift-4.19 in a new PR and assign it to you.

In response to this:

/cherrypick openshift-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@joepvd
Copy link
Contributor

joepvd commented Nov 7, 2024

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 7, 2024
Copy link
Contributor

openshift-ci bot commented Nov 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: joepvd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 7, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 0fbda55 into openshift-eng:openshift-4.18 Nov 7, 2024
2 checks passed
@openshift-cherrypick-robot

@joepvd: new pull request created: #5629

In response to this:

/cherrypick openshift-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants