Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[openshift-4.17] pin go tools with previous version to match golang version #5401

Conversation

openshift-cherrypick-robot

This is an automated cherry-pick of #5371

/assign Ximinhan

Copy link

@locriandev locriandev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/openshift-eng/ocp-build-data/blob/openshift-4.17/ci_images/rhel-8/ci-openshift-build-root/Dockerfile#L46 still has go install golang.org/x/tools/cmd/cover@latest, which has correctly been removed from Dockerfile.previous. We should update that Dockerfile, and its rhel 9 counterpart.

@joepvd I saw this slipped from #5371

Copy link
Contributor

openshift-ci bot commented Sep 18, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from ximinhan. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Ximinhan
Copy link

https://github.com/openshift-eng/ocp-build-data/blob/openshift-4.17/ci_images/rhel-8/ci-openshift-build-root/Dockerfile#L46 still has go install golang.org/x/tools/cmd/cover@latest, which has correctly been removed from Dockerfile.previous. We should update that Dockerfile, and its rhel 9 counterpart.

@joepvd I saw this slipped from #5371

@locriandev the dockerfile.previous is used for go 1.21, and Dockerfile can be used for go 1.22, the cover@latest can work with go 1.22

@locriandev
Copy link

@Ximinhan what's the point in sticking to install golang.org/x/tools/cmd/cover, even though it's bundled in the core toolchain?

@Ximinhan
Copy link

@Ximinhan what's the point in sticking to install golang.org/x/tools/cmd/cover, even though it's bundled in the core toolchain?

you mean in the dockerfile for go 1.22, it will auto skipped when install tools, I updated in #5413

@Ximinhan
Copy link

I can't edit cherrypick branch, replace with #5413

@Ximinhan Ximinhan closed this Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants