ART-11093 add ignore_non_x86_nightlies arg for gen-assembly #1104
Conversation
they are a little bit different, the LIMIT_ARCH needs to be used with skip_get_nightlies and use the inputted nightly to get candidate_nightlies and rhcos is also limited by that arch config. |
| if self.skip_get_nightlies: | ||
| candidate_nightlies = self.nightlies | ||
| elif self.ignore_non_x86_nightlies: | ||
| candidate_nightlies = await self._get_latest_accepted_nightly() |
There was a problem hiding this comment.
Looks like setting this option will cause the pipeline completely ignore the --nightly parameter. Is there a way to fix that?
There was a problem hiding this comment.
this is the design, when ignore_non_x86_nightlies set only use latest accepted x86 nightly.
nightly parameter is used with skip_get_nightlies, if skip_get_nightlies is true the input value of nighties set will be used.
There was a problem hiding this comment.
you're setting what's supposed to be a var of list of nightlies to a single nightly.. how does that work?
Is this code tested?
There was a problem hiding this comment.
this is what we want, if ignore_non_x86_nightlies is true we only use x86_64 nightly and build the assembly as we did with all arch nightly, we use x86_64 nightly get brew event and get full arch of rhcos from the rhcos version in x86_64 nightly
Ximinhan
added
the
tide/merge-method-squash
Ximinhan
force-pushed
the
art-11093-1
branch
from
72cbe4e to
770c182
Compare
|
@Ximinhan: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: joepvd The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
openshift-merge-bot
bot
merged commit f370fb5
into
openshift-eng:main
add ignore_non_x86_nightlies arg, if this arg is checked then it will only use latest accepted x86_64 nightly, default to False.
this arg honors the skip_get_nightlies arg, if skip_get_nightlies is true the input value of nighties set will be used.
Tested with https://art-jenkins.apps.prod-stable-spoke1-dc-iad2.itup.redhat.com/job/hack/job/ximhan/job/build%252Fgen-assembly/5/consoleFull
and it created assembly pr openshift-eng/ocp-build-data#5832
only have x86_64 nightly, but full arch of RHCOS and the brew event come from x86_64 nightly