Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8312488: tools/jpackage/share/AppLauncherEnvTest.java fails with dynamically linked libstdc++ #1271

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

yaqsun
Copy link
Contributor

@yaqsun yaqsun commented Dec 19, 2024

Apply clean.And test have been locally verified to pass.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8312488 needs maintainer approval

Issue

  • JDK-8312488: tools/jpackage/share/AppLauncherEnvTest.java fails with dynamically linked libstdc++ (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1271/head:pull/1271
$ git checkout pull/1271

Update a local copy of the PR:
$ git checkout pull/1271
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1271/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1271

View PR using the GUI difftool:
$ git pr show -t 1271

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1271.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 19, 2024

👋 Welcome back yaqsun! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 19, 2024

@yaqsun This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8312488: tools/jpackage/share/AppLauncherEnvTest.java fails with dynamically linked libstdc++

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport 78a8a99d990dcc0b77c096bb2ca2c1bb86462e3f 8312488: tools/jpackage/share/AppLauncherEnvTest.java fails with dynamically linked libstdc++ Dec 19, 2024
@openjdk
Copy link

openjdk bot commented Dec 19, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Dec 19, 2024

⚠️ @yaqsun This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 19, 2024
@mlbridge
Copy link

mlbridge bot commented Dec 19, 2024

Webrevs

@yaqsun
Copy link
Contributor Author

yaqsun commented Dec 19, 2024

/approval 8312488 request Fix tools/jpackage/share/AppLauncherEnvTest.java fails with dynamically linked libstdc++

@openjdk
Copy link

openjdk bot commented Dec 19, 2024

@yaqsun
8312488: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Dec 19, 2024
@GoeLin
Copy link
Member

GoeLin commented Dec 20, 2024

Hi @yaqsun
how did you test this? What is the risk of the backport? Why do the GHA tests fail?

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Dec 22, 2024
@yaqsun
Copy link
Contributor Author

yaqsun commented Dec 23, 2024

Hi @yaqsun how did you test this? What is the risk of the backport? Why do the GHA tests fail?

The tests passed after the retry.

@yaqsun
Copy link
Contributor Author

yaqsun commented Dec 24, 2024

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Dec 24, 2024
@openjdk
Copy link

openjdk bot commented Dec 24, 2024

@yaqsun
Your change (at version b7e3eee) is now ready to be sponsored by a Committer.

@GoeLin
Copy link
Member

GoeLin commented Dec 24, 2024

Hi @yaqsun how did you test this? What is the risk of the backport? Why do the GHA tests fail?

The tests passed after the retry.
This does not answer any of my questions above.
Please have a look at https://wiki.openjdk.org/display/JDKUpdates/How+to+contribute+or+backport+a+fix
It;s a good idea to restart the tests if they failed due to an infrastructure issue, but before that you shoudl have a look whether that was the case.

@yaqsun
Copy link
Contributor Author

yaqsun commented Jan 15, 2025

Hi @yaqsun how did you test this?

I tested tier1 locally and the results are as follows.

==============================
Test summary
==============================
   TEST                                              TOTAL  PASS  FAIL ERROR   
>> jtreg:test/hotspot/jtreg:tier1                     2430  2430     0     0
   jtreg:test/jdk:tier1                               2376  2376     0     0   
   jtreg:test/langtools:tier1                         4415  4415     0     0   
   jtreg:test/jaxp:tier1                                 0     0     0     0   
   jtreg:test/lib-test:tier1                            33    33     0     0 

What is the risk of the backport?

The risk of backport is still under evaluation.

Why do the GHA tests fail?

That seems to be a compilation error, so I think it's caused by an infrastructure issue. I want to verify if it's an infrastructure issue, so I started the tests again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored
Development

Successfully merging this pull request may close these issues.

2 participants