-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8312488: tools/jpackage/share/AppLauncherEnvTest.java fails with dynamically linked libstdc++ #1271
base: master
Are you sure you want to change the base?
Conversation
👋 Welcome back yaqsun! A progress list of the required criteria for merging this PR into |
@yaqsun This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. ➡️ To flag this PR as ready for integration with the above commit message, type |
This backport pull request has now been updated with issue from the original commit. |
|
Webrevs
|
/approval 8312488 request Fix tools/jpackage/share/AppLauncherEnvTest.java fails with dynamically linked libstdc++ |
Hi @yaqsun |
The tests passed after the retry. |
/integrate |
|
I tested tier1 locally and the results are as follows.
The risk of backport is still under evaluation.
That seems to be a compilation error, so I think it's caused by an infrastructure issue. I want to verify if it's an infrastructure issue, so I started the tests again. |
Apply clean.And test have been locally verified to pass.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1271/head:pull/1271
$ git checkout pull/1271
Update a local copy of the PR:
$ git checkout pull/1271
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1271/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1271
View PR using the GUI difftool:
$ git pr show -t 1271
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1271.diff
Using Webrev
Link to Webrev Comment