Changes done in launch file to disable doSecondReset and removed dupl… #40
Conversation
…icated genHiMaxCamClock function in tensorflow perdet main.c
There was a problem hiding this comment.
Looks good to me @someshwar-ms. I have a comment/request about the hs2 launch file.
| @@ -42,7 +42,7 @@ | |||
| <booleanAttribute key="org.eclipse.cdt.debug.gdbjtag.core.useProjBinaryForImage" value="true"/> | |||
| <booleanAttribute key="org.eclipse.cdt.debug.gdbjtag.core.useProjBinaryForSymbols" value="true"/> | |||
| <booleanAttribute key="org.eclipse.cdt.debug.gdbjtag.core.useRemoteTarget" value="true"/> | |||
| <stringAttribute key="org.eclipse.cdt.dsf.gdb.DEBUG_NAME" value="/opt/corev-openhw-gcc-ubuntu1804-20200913/bin/riscv32-corev-elf-gdb"/> | |||
| <stringAttribute key="org.eclipse.cdt.dsf.gdb.DEBUG_NAME" value="/opt/corev-openhw-gcc-ubuntu2004-20200913/bin/riscv32-corev-elf-gdb"/> | |||
There was a problem hiding this comment.
This is a hard-coded path which makes it very difficult to support "general users". Is there a way to shell environment variables for this? For example, if a user had the toolchain installed in COREV_TOOLCHAIN_HOME:
<stringAttribute key="org.eclipse.cdt.dsf.gdb.DEBUG_NAME" value="$COREV_TOOLCHAIN_HOME/bin/riscv32-corev-elf-gdb"/>
I am not sure if Eclipse can read shell environment variables from a launch file, but we need to be able to support users who install the toolchain in arbitrary places.
There was a problem hiding this comment.
Hi Mike,
Yes, this path for gdb bin location is hard-coded to point to opt folder. There is another issue here. For Ubuntu 18.04, there is a different tool-chain and for 20.04 there is another. Different users might use different versions of Ubuntu. We need to take this into account as well.
The reason I touched this launch file was to correct the doSecondReset flag, as the debugger launch will fail with this set to true and will not work out of the box.
Unfortunately I don't know how to make these settings a generic one.
For making the paths generic maybe core-v-mcu SDK development folks might help us?
Thanks,
Somesh
There was a problem hiding this comment.
We face this exact same issue in simulation verification @someshwar-ms. I will post a message to MatterMost to see if one of the OpenHW Group Contributors has a solution. There must be a way to do this intelligently.
Changes done in launch file to disable doSecondReset and removed duplicated genHiMaxCamClock function in tensorflow perdet main.c