-
-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sitemap treeview: Fix arrows/chevrons shown if not expandable #3007
Sitemap treeview: Fix arrows/chevrons shown if not expandable #3007
Conversation
Regression from openhab#2904. Reported in openhab#2970 (comment). Signed-off-by: Florian Hotze <dev@florianhotze.com>
#2695 Bundle Size — 10.98MiB (~+0.01%).a8d2be5(current) vs e7d9b65 main#2689(baseline) Warning Bundle contains 2 duplicate packages – View duplicate packages Bundle metrics
|
Current #2695 |
Baseline #2689 |
|
---|---|---|
Initial JS | 1.9MiB |
1.9MiB |
Initial CSS | 577.21KiB |
577.21KiB |
Cache Invalidation | 17.51% |
19.12% |
Chunks | 227 |
227 |
Assets | 250 |
250 |
Modules | 2950 |
2950 |
Duplicate Modules | 154 |
154 |
Duplicate Code | 1.8% |
1.8% |
Packages | 98 |
98 |
Duplicate Packages | 2 |
2 |
Bundle size by type 1 change
1 regression
Current #2695 |
Baseline #2689 |
|
---|---|---|
JS | 9.19MiB (~+0.01% ) |
9.19MiB |
CSS | 867.02KiB |
867.02KiB |
Fonts | 526.1KiB |
526.1KiB |
Media | 295.6KiB |
295.6KiB |
IMG | 140.74KiB |
140.74KiB |
HTML | 1.38KiB |
1.38KiB |
Other | 871B |
871B |
Bundle analysis report Branch florian-h05:sitemap-treeview-che... Project dashboard
Generated by RelativeCI Documentation Report issue
Thanks. I didn't test yet, but LGTM |
Too late for 4.3.2? |
#2904 is no part of 4.3.x at all, no need to backport this at all. |
Indeed, sorry. |
@florian-h05 Did you test this? I tried replicating this logic for the model tree-view, but the expansion icons still show. I had to explicitely set the |
Yes, I tested this and it worked fine. |
OK, I now understand why this works here, but not in the model treeview. The difference is that I made sure there is an empty slot in the children in this case. |
bundles/org.openhab.ui/web/src/components/pagedesigner/sitemap/treeview-item.vue
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove v-if="canHaveChildren"
from line 10.
Add :toggle="canHaveChildren"
around line 6.
Signed-off-by: Florian Hotze <dev@florianhotze.com>
Let's align the implementation - I have just implemented your review comments. |
Regression from #2904.
Reported in #2970 (comment).