Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace @edx/paragon and @edx/frontend-build #1120

Closed
wants to merge 1 commit into from

Conversation

Mashal-m
Copy link
Contributor

@Mashal-m Mashal-m commented Dec 29, 2023

Description

Part of openedx/axim-engineering#23

This replaces the @edx/paragon and @edx/frontend-build package.
Imports have been updated to use the same locations in the new package.

JIRA

XXX-XXXX

How Has This Been Tested?

Please describe in detail how you tested your changes.

Screenshots/sandbox (optional):

Include a link to the sandbox for design changes or screenshot for before and after. Remove this section if its not applicable.

Before After

Merge Checklist

  • If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Sandbox, if applicable.
  • Is there adequate test coverage for your changes?

Post-merge Checklist

  • Deploy the changes to prod after verifying on stage or ask @openedx/vanguards to do it.
  • 🎉 🙌 Celebrate! Thanks for your contribution.

Copy link

codecov bot commented Dec 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (10a10c8) 87.11% compared to head (cabc565) 87.11%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1120   +/-   ##
=======================================
  Coverage   87.11%   87.11%           
=======================================
  Files         124      124           
  Lines        2282     2282           
  Branches      637      637           
=======================================
  Hits         1988     1988           
  Misses        285      285           
  Partials        9        9           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zainab-amir
Copy link
Contributor

@Mashal-m is this change still needed? I see that the work has already been done and merged as part of this PR: #1132

@BilalQamar95
Copy link
Contributor

Closing since these package upgrades were taken care of as a part of #1132

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants