Skip to content

Commit

Permalink
fix: Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Brian Smith <112954497+brian-smith-tcril@users.noreply.github.com>
  • Loading branch information
OmarIthawi and brian-smith-tcril authored Feb 1, 2024
1 parent 94a194b commit 78efeba
Showing 1 changed file with 3 additions and 6 deletions.
9 changes: 3 additions & 6 deletions source/developers/how-tos/enable-translations-new-repo.rst
Original file line number Diff line number Diff line change
Expand Up @@ -45,9 +45,7 @@ workflow:
- Django plugins: ``django.po``
- If the repo uses ``gettext`` and has a ``static`` directory with JavaScript, it may include ``djangojs.po``

#. If XBlock JavaScript translations is needed, use the ``XBlockI18NService.get_javascript_i18n_catalog_url`` method
similar to the `Drag and Drop XBlock XBlockI18NService js translations pull request`_. This method is available as
of `Open edX Redwood XBlock translations feature`_ and `XBlock==1.9.1 release`_.
#. If you need JavaScript translations in your XBlock, use ``XBlockI18NService.get_javascript_i18n_catalog_url``. You can find an example of this in ``_get_statici18n_js_url`` in ``xblock-drag-and-drop-v2/`` `here <https://github.com/openedx/xblock-drag-and-drop-v2/blob/3900a4eba5befbbaea636c5e256aaabcd985e64d/drag_and_drop_v2/drag_and_drop_v2.py#L343-L349>`_. Note: this requires `XBlock 1.9.1`_ or newer, and `edx-platform e7fc0c6`_ or newer.

#. Add the repository to `extract-translation-source-files.yml`_ in the `openedx-translations repo`_.

Expand Down Expand Up @@ -264,9 +262,8 @@ After adding a repository to the `openedx-translations repo`_ verify the followi
.. _frontend-lib-special-exams testing pull request: https://github.com/Zeit-Labs/openedx-translations/pull/1/files
.. _transifex.yml: https://github.com/openedx/openedx-translations/blob/main/transifex.yml
.. _Drag and Drop XBlock transifex.yml entry: https://github.com/openedx/openedx-translations/blob/19c0fcbbc334c56022df355fa5b529e5853d30f9/transifex.yml#L253-L259
.. _Drag and Drop XBlock XBlockI18NService js translations pull request: https://github.com/openedx/xblock-drag-and-drop-v2/pull/365/files#diff-fe829a32b6885a4d3c06b0710a0f38ed86a773e090e269356fcc5c934b42b50fR343-R349
.. _Open edX Redwood XBlock translations feature: https://github.com/openedx/edx-platform/pull/33698
.. _XBlock==1.9.1 release: https://github.com/openedx/XBlock/pull/702
.. _edx-platform e7fc0c6: https://github.com/openedx/edx-platform/commit/e7fc0c6b6f8b44fa4bcc71d00ae2931f91cc664c
.. _XBlock 1.9.1: https://github.com/openedx/XBlock/releases/tag/xblock-1.9.1

.. _edx-platform: https://github.com/openedx/edx-platform
.. _credentials: https://github.com/openedx/credentials
Expand Down

0 comments on commit 78efeba

Please sign in to comment.