Skip to content
This repository has been archived by the owner on Aug 1, 2024. It is now read-only.

Feat:Auto-sync dependencies between code and virtual env for lms #1068

Closed

Conversation

XLAR-8
Copy link

@XLAR-8 XLAR-8 commented May 13, 2023

Solves issue: devstack/issues/1028

description:
Auto-sync dependencies between code and virtual env for LMS for now, can be extended for other services too.


I've completed each of the following or determined they are not applicable:

  • Made a plan to communicate any major developer interface changes (or N/A)

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label May 13, 2023
@openedx-webhooks
Copy link

openedx-webhooks commented May 13, 2023

Thanks for the pull request, @XLAR-8! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@itsjeyd
Copy link

itsjeyd commented May 16, 2023

Hi @XLAR-8, thank you for this contribution!

As the bot mentioned, the next step will be for you to sign the Open edX Contributor Agreement.

Then we can enable tests for this PR, and get it into the review queue.

@itsjeyd itsjeyd added the waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. label May 16, 2023
@XLAR-8
Copy link
Author

XLAR-8 commented May 22, 2023

@itsjeyd I have already sign the Open edX Contributor Agreement.

@itsjeyd
Copy link

itsjeyd commented May 23, 2023

@XLAR-8 Great! As the bot mentioned above, the next step will be to trigger another run of the CLA check; you can do that by editing (and saving) the PR title.

@XLAR-8 XLAR-8 changed the title Feat:Auto-sync dependencies between code and virtual env for lms Feat:Auto-sync dependencies between code and virtual env for lms May 24, 2023
@XLAR-8 XLAR-8 changed the title Feat:Auto-sync dependencies between code and virtual env for lms Feat:Auto-sync dependencies between code and virtual env for lms May 24, 2023
@itsjeyd
Copy link

itsjeyd commented May 31, 2023

Hey @XLAR-8, now that the CLA check passed, could you please rebase your branch on latest master (or merge the latest commits)? Once that's done we'll kick off a test run.

@itsjeyd itsjeyd added the needs test run Author's first PR to this repository, awaiting test authorization from Axim label May 31, 2023
@e0d
Copy link
Contributor

e0d commented May 31, 2023

Updating via a merge commit, which will re-run the tests.

@e0d
Copy link
Contributor

e0d commented May 31, 2023

@XLAR-8 looks like several of the provisions are failing with this change, can you have a look?

@e0d e0d removed the needs test run Author's first PR to this repository, awaiting test authorization from Axim label May 31, 2023
@itsjeyd
Copy link

itsjeyd commented Jun 7, 2023

@XLAR-8 A friendly reminder to have a look at the tests that are failing here.

Once everything is green we'll line up your changes for engineering review.

@itsjeyd
Copy link

itsjeyd commented Jul 11, 2023

Hi @XLAR-8, just checking in to see if we should keep this PR open?

@XLAR-8 XLAR-8 closed this Jul 19, 2023
@openedx-webhooks
Copy link

@XLAR-8 Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

@itsjeyd itsjeyd removed the waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. label Jul 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants