-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ODH release workflow #17
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Just a couple of small comments.
2000f5c
to
801ec7d
Compare
Pull Request Test Coverage Report for Build 11439915191Details
💛 - Coveralls |
801ec7d
to
cbaa088
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@oksanabaza |
Hey @ChughShilpa , this is a good point, I haven't as I need a token to test it |
You can test it by adding a token in your fork and then try running the workflow |
@ChughShilpa I tested the workflow with my personal GitHub token in my fork, and it worked fine. However, when I tried to run the workflow in the fork using the |
Yes right, |
Just FYI, it is good to add the workflow link which you ran manually in the description of the PR stating how you tested this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
thanks @ChughShilpa, I will update the description |
cbaa088
to
75d9dc9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
What this PR does / why we need it:
Adding a release workflow in the ODH fork of Training Operator
Which issue(s) this PR fixes (optional, in
Fixes #<issue number>, #<issue number>, ...
format, will close the issue(s) when PR gets merged):Fixes #
https://issues.redhat.com/browse/RHOAIENG-13631
This workflow has been tested locally using my personal GH token here
Checklist: