Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update manifest to use ODH KFTO image #12

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

oksanabaza
Copy link

RHOAIENG-12187

What this PR does / why we need it:

Update manifest and makefile in order to use ODH image from quay.io

Which issue(s) this PR fixes (optional, in Fixes #<issue number>, #<issue number>, ... format, will close the issue(s) when PR gets merged):
Fixes #

Checklist:

  • Docs included if any changes are user facing

@coveralls
Copy link

coveralls commented Sep 16, 2024

Pull Request Test Coverage Report for Build 10940870205

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall first build on build-image-flow at 42.842%

Totals Coverage Status
Change from base Build 10112730546: 42.8%
Covered Lines: 3750
Relevant Lines: 8753

💛 - Coveralls

@oksanabaza oksanabaza marked this pull request as draft September 16, 2024 14:06
@oksanabaza oksanabaza marked this pull request as ready for review September 16, 2024 15:50
Copy link

@Fiona-Waters Fiona-Waters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on my rosa cluster and this change works as expected. Not sure about the failing pr checks here but otherwise it looks good to me.

@astefanutti
Copy link

That looks good. @oksanabaza @Fiona-Waters Do you think we could update the GH actions workflow to tag the container image according to the release tag? I think that'd be something useful.

@oksanabaza
Copy link
Author

Hey @astefanutti , do we want to build and push the image every time a release is published, or should we also keep building and pushing on PR and push actions?

@astefanutti
Copy link

@oksanabaza I'd say at the minimum every time a release is published. I don't have a strong opinion for keeping a latest rolling tag that'd be published on push. Maybe it's useful to test the latest changes before next release. WDYT?

@oksanabaza
Copy link
Author

@astefanutti sounds good, I'll keep the PR and push events handled as well. Thank you!

Copy link

@astefanutti astefanutti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@astefanutti
Copy link

@oksanabaza it seems there is something wrong with the definition of the tags: Error: Invalid event for type=ref,event=release,ref=tags.

The integration tests have been failing ever since the fork got created. That's unrelated and we can look at that separately.

@oksanabaza oksanabaza force-pushed the build-image-flow branch 2 times, most recently from ae95ad8 to 759796b Compare September 19, 2024 12:28
@oksanabaza
Copy link
Author

@astefanutti thank you, the issue has been fixed

@astefanutti astefanutti merged commit 130c890 into opendatahub-io:dev Sep 25, 2024
6 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants