-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update manifest to use ODH KFTO image #12
Conversation
Pull Request Test Coverage Report for Build 10940870205Details
💛 - Coveralls |
3a444b5
to
8bd9dcb
Compare
8bd9dcb
to
3c8765e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on my rosa cluster and this change works as expected. Not sure about the failing pr checks here but otherwise it looks good to me.
That looks good. @oksanabaza @Fiona-Waters Do you think we could update the GH actions workflow to tag the container image according to the release tag? I think that'd be something useful. |
Hey @astefanutti , do we want to build and push the image every time a release is published, or should we also keep building and pushing on PR and push actions? |
@oksanabaza I'd say at the minimum every time a release is published. I don't have a strong opinion for keeping a |
@astefanutti sounds good, I'll keep the PR and push events handled as well. Thank you! |
3c8765e
to
5f32e5b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@oksanabaza it seems there is something wrong with the definition of the tags: The integration tests have been failing ever since the fork got created. That's unrelated and we can look at that separately. |
ae95ad8
to
759796b
Compare
@astefanutti thank you, the issue has been fixed |
759796b
to
3ef5f06
Compare
RHOAIENG-12187
What this PR does / why we need it:
Update manifest and makefile in order to use ODH image from quay.io
Which issue(s) this PR fixes (optional, in
Fixes #<issue number>, #<issue number>, ...
format, will close the issue(s) when PR gets merged):Fixes #
Checklist: