Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add codecoverage badge to Readme #1493

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

biswassri
Copy link
Contributor

@biswassri biswassri commented Jan 10, 2025

Description

Adding a codecov badge to see the overall code coverage status of the repo

How Has This Been Tested?

Screenshot or short clip

Merge criteria

  • You have read the contributors guide.
  • Commit messages are meaningful - have a clear and concise summary and detailed explanation of what was changed and why.
  • Pull Request contains a description of the solution, a link to the JIRA issue, and to any dependent or related Pull Request.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@openshift-ci openshift-ci bot requested review from VaishnaviHire and zdtsw January 10, 2025 14:45
@biswassri
Copy link
Contributor Author

/cc @grdryn @asanzgom

@openshift-ci openshift-ci bot requested review from asanzgom and grdryn January 10, 2025 14:47
@zdtsw
Copy link
Member

zdtsw commented Jan 10, 2025

i am not against but also try to understand the reason behind this.

@biswassri
Copy link
Contributor Author

i am not against but also try to understand the reason behind this.

Just a follow-up to #1492 to have a batch showing the overall code coverage status of the repo.

@biswassri
Copy link
Contributor Author

/retest

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 18.72%. Comparing base (4685177) to head (a7b2725).
Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1493   +/-   ##
=======================================
  Coverage   18.72%   18.72%           
=======================================
  Files         154      154           
  Lines       10282    10282           
=======================================
  Hits         1925     1925           
  Misses       8145     8145           
  Partials      212      212           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@biswassri biswassri changed the title chore: add codecoverage batch to Readme chore: add codecoverage badge to Readme Jan 10, 2025
Copy link
Member

@grdryn grdryn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

openshift-ci bot commented Jan 14, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: grdryn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 8865ea6 into opendatahub-io:main Jan 14, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants