Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update codecov-actions version and add codecov config file to repo #1489

Conversation

asanzgom
Copy link
Contributor

@asanzgom asanzgom commented Jan 9, 2025

Description

Updating the codecov-actions version for the unit tests Github actions workflow to the latest 5.1.2 version + adding codecov config yaml file at repo level to define main branch as default

How Has This Been Tested?

Screenshot or short clip

Merge criteria

  • You have read the contributors guide.
  • Commit messages are meaningful - have a clear and concise summary and detailed explanation of what was changed and why.
  • Pull Request contains a description of the solution, a link to the JIRA issue, and to any dependent or related Pull Request.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@asanzgom
Copy link
Contributor Author

asanzgom commented Jan 9, 2025

/assign grdryn

@asanzgom
Copy link
Contributor Author

asanzgom commented Jan 9, 2025

/unassign grdryn

@asanzgom
Copy link
Contributor Author

asanzgom commented Jan 9, 2025

/cc grdryn

@openshift-ci openshift-ci bot requested a review from grdryn January 9, 2025 15:35
@asanzgom
Copy link
Contributor Author

asanzgom commented Jan 9, 2025

/cc vhire

Copy link

openshift-ci bot commented Jan 9, 2025

@asanzgom: GitHub didn't allow me to request PR reviews from the following users: vhire.

Note that only opendatahub-io members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc vhire

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@asanzgom
Copy link
Contributor Author

asanzgom commented Jan 9, 2025

/cc VaishnaviHire

@openshift-ci openshift-ci bot requested a review from VaishnaviHire January 9, 2025 15:36
@asanzgom
Copy link
Contributor Author

asanzgom commented Jan 9, 2025

/cc wenzhou

Copy link

openshift-ci bot commented Jan 9, 2025

@asanzgom: GitHub didn't allow me to request PR reviews from the following users: wenzhou.

Note that only opendatahub-io members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc wenzhou

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@asanzgom
Copy link
Contributor Author

asanzgom commented Jan 9, 2025

/cc zdtsw

@openshift-ci openshift-ci bot requested a review from zdtsw January 9, 2025 15:38
@asanzgom
Copy link
Contributor Author

asanzgom commented Jan 9, 2025

/cc CFSNM

@openshift-ci openshift-ci bot requested a review from CFSNM January 9, 2025 15:38
@asanzgom
Copy link
Contributor Author

asanzgom commented Jan 9, 2025

/cc MarianMacik

@openshift-ci openshift-ci bot requested a review from MarianMacik January 9, 2025 15:39
@asanzgom
Copy link
Contributor Author

asanzgom commented Jan 9, 2025

/assign asanzgom

@openshift-ci openshift-ci bot added the lgtm label Jan 9, 2025
Copy link

openshift-ci bot commented Jan 9, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CFSNM

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Jan 9, 2025
@asanzgom
Copy link
Contributor Author

asanzgom commented Jan 9, 2025

/unassign CFSNM

@openshift-ci openshift-ci bot unassigned CFSNM Jan 9, 2025
Copy link
Member

@MarianMacik MarianMacik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Not approving to leave others room for their reviews.

codecov.yml Show resolved Hide resolved
@AjayJagan
Copy link
Contributor

lgtm

@grdryn
Copy link
Member

grdryn commented Jan 9, 2025

/retest

@openshift-merge-bot openshift-merge-bot bot merged commit 524e4c2 into opendatahub-io:main Jan 9, 2025
8 checks passed
Copy link

codecov bot commented Jan 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@fe44f28). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1489   +/-   ##
=======================================
  Coverage        ?   18.72%           
=======================================
  Files           ?      154           
  Lines           ?    10280           
  Branches        ?        0           
=======================================
  Hits            ?     1925           
  Misses          ?     8143           
  Partials        ?      212           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@asanzgom asanzgom deleted the feature/update_codecov_action_version branch January 10, 2025 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants