Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: KServe InferenceGraph auth configurations #1483

Closed
wants to merge 1 commit into from
Closed

feat: KServe InferenceGraph auth configurations #1483

wants to merge 1 commit into from

Conversation

israel-hdez
Copy link
Contributor

@israel-hdez israel-hdez commented Jan 9, 2025 •
edited
Loading

Description

This adds resources required to support auth for KServe InferenceGraphs.

https://issues.redhat.com/browse/RHOAIENG-13449

Other related PRs:

How Has This Been Tested?

  1. Deploy operator
  2. Install KServe
  3. Check that the new resources are present

Merge criteria

  • You have read the contributors guide.
  • Commit messages are meaningful - have a clear and concise summary and detailed explanation of what was changed and why.
  • Pull Request contains a description of the solution, a link to the JIRA issue, and to any dependent or related Pull Request.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@israel-hdez
feat: KServe InferenceGraph auth configurations
3a07c13 
This adds resources required to support auth for KServe InferenceGraphs.

Signed-off-by: Edgar Hernández <23639005+israel-hdez@users.noreply.github.com>
@openshift-ci openshift-ci bot requested review from lburgazzoli and zdtsw January 9, 2025 00:07
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jan 9, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign ykaliuta for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@israel-hdez israel-hdez mentioned this pull request Jan 9, 2025
Merged
3 tasks
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jan 9, 2025

@israel-hdez: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/opendatahub-operator-e2e 3a07c13 link true /test opendatahub-operator-e2e
ci/prow/opendatahub-operator-pr-image-mirror 3a07c13 link true /test opendatahub-operator-pr-image-mirror

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@zdtsw
Copy link
Member

zdtsw commented Jan 9, 2025

think we will need to use the new code base "main" branch for this feature.

zdtsw
zdtsw reviewed Jan 9, 2025
View reviewed changes
components/kserve/resources/servicemesh/kserve-inferencegraph-authorizationpolicy.tmpl.yaml
@@ -0,0 +1,23 @@
apiVersion: security.istio.io/v1beta1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move it to https://github.com/opendatahub-io/opendatahub-operator/tree/main/controllers/components/kserve/resources/servicemesh

components/kserve/resources/servicemesh/kserve-inferencegraph-envoyfilter.tmpl.yaml
@@ -0,0 +1,43 @@
apiVersion: networking.istio.io/v1alpha3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move it to https://github.com/opendatahub-io/opendatahub-operator/tree/main/controllers/components/kserve/resources/servicemesh

components/kserve/servicemesh_setup.go
@@ -52,6 +52,8 @@ func (k *Kserve) defineServiceMeshFeatures(ctx context.Context, cli client.Clien
path.Join(Resources.ServiceMeshDir, "activator-envoyfilter.tmpl.yaml"),
path.Join(Resources.ServiceMeshDir, "envoy-oauth-temp-fix.tmpl.yaml"),
path.Join(Resources.ServiceMeshDir, "kserve-predictor-authorizationpolicy.tmpl.yaml"),
path.Join(Resources.ServiceMeshDir, "kserve-inferencegraph-envoyfilter.tmpl.yaml"),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update after https://github.com/opendatahub-io/opendatahub-operator/blob/main/controllers/components/kserve/kserve_support.go#L117

@israel-hdez
Copy link
Contributor Author

israel-hdez commented Jan 9, 2025 •
edited
Loading

@zdtsw I fixed your comments in another PR, as I'm not sure if this should be closed: #1491.
I'd like these changes to go to the next release.

Feel free to close if this one is no longer relevant.

@zdtsw zdtsw closed this Jan 10, 2025
@israel-hdez israel-hdez deleted the j13449-ig-auth-mesh-configs branch January 10, 2025 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zdtsw zdtsw zdtsw left review comments

@lburgazzoli lburgazzoli Awaiting requested review from lburgazzoli

Assignees
No one assigned
Labels
None yet
Projects
ODH Platform Planning
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@israel-hdez @zdtsw