chore: Remove unused yq test matchers package

[grdryn]

Description

Since this appears to be unused, it seems like a good idea to remove
it, since that causes a bunch of dependencies to be removed from the
go.mod file.

How Has This Been Tested?

n/a

Screenshot or short clip

Merge criteria

• You have read the contributors guide.
• Commit messages are meaningful - have a clear and concise summary and detailed explanation of what was changed and why.
• Pull Request contains a description of the solution, a link to the JIRA issue, and to any dependent or related Pull Request.
• Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
• The developer has manually tested the changes and verified that the changes work

[lburgazzoli]

/lgtm

[lburgazzoli]

/test opendatahub-operator-e2e

[grdryn]

/retest

[lburgazzoli]

@grdryn failures are probably related to #1479

[grdryn]

/retest

[lburgazzoli]

@grdryn you may need to rebase to get the propagation policy fix

[grdryn]

@grdryn you may need to rebase to get the propagation policy fix

I think Prow tests the merge of the source branch into the target branch, rather than just the tip of the source branch. If it fails then I'll rebase 🙂

[lburgazzoli]

@grdryn you may need to rebase to get the propagation policy fix

I think Prow tests the merge of the source branch into the target branch, rather than just the tip of the source branch. If it fails then I'll rebase 🙂

Ah ok, just saw GitHub notification:

[grdryn]

Huh, seems like it's not 🤔 I wonder if I have the wrong understanding in general or if we've got it configured differently for this project. Or maybe it does that merge test before merging only if it determines that the target has changed compared to what it previously tested against.

In any case, I'll rebase now 🙂

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@95f696a). Learn more about missing BASE report.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1478   +/-   ##
=======================================
  Coverage        ?   18.72%           
=======================================
  Files           ?      154           
  Lines           ?    10276           
  Branches        ?        0           
=======================================
  Hits            ?     1924           
  Misses          ?     8139           
  Partials        ?      213           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[lburgazzoli]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lburgazzoli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [lburgazzoli]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment