[sync] Update golang.org/x/net to v0.33.0 (#1463) #1471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change is to update to a version that isn't flagged as affected by CVE-2024-45338. While we know that this operator doesn't call the vulnerable code paths (hooray for `govulncheck`), some scanning tools are not yet smart enough to be able to discern that. So it's preferable just to update. Go advisory: https://pkg.go.dev/vuln/GO-2024-3333 (cherry picked from commit b36c13a)
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: grdryn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## rhoai #1471 +/- ##
========================================
Coverage ? 18.87%
========================================
Files ? 30
Lines ? 3338
Branches ? 0
========================================
Hits ? 630
Misses ? 2639
Partials ? 69 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is to update to a version that isn't flagged as affected by CVE-2024-45338.
While we know that this operator doesn't call the vulnerable code paths (hooray for
govulncheck), some scanning tools are not yet smart enough to be able to discern that. So it's preferable just to update.Go advisory: https://pkg.go.dev/vuln/GO-2024-3333
(cherry picked from commit b36c13a)
Description
How Has This Been Tested?
Screenshot or short clip
Merge criteria