Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update platform owners list #1459

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

grdryn
Copy link
Member

@grdryn grdryn commented Dec 18, 2024


Description

This change just removes folks from the platform owner alias who are
no longer involved with the project. This means that they will no
longer get annoyed by the automation selecting them for reviews.

How Has This Been Tested?

n/a

Screenshot or short clip

n/a

Merge criteria

  • You have read the contributors guide.
  • Commit messages are meaningful - have a clear and concise summary and detailed explanation of what was changed and why.
  • Pull Request contains a description of the solution, a link to the JIRA issue, and to any dependent or related Pull Request.

@openshift-ci openshift-ci bot requested review from asanzgom and CFSNM December 18, 2024 12:47
@grdryn
Copy link
Member Author

grdryn commented Dec 18, 2024

/override ci/prow/opendatahub-operator-e2e

The e2e test doesn't matter for this change, so there's no need to block it on infra issues with that test.

Copy link

openshift-ci bot commented Dec 18, 2024

@grdryn: Overrode contexts on behalf of grdryn: ci/prow/opendatahub-operator-e2e

In response to this:

/override ci/prow/opendatahub-operator-e2e

The e2e test doesn't matter for this change, so there's no need to block it on infra issues with that test.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

codecov bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@8e1b8f5). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1459   +/-   ##
=======================================
  Coverage        ?   19.11%           
=======================================
  Files           ?      157           
  Lines           ?    10356           
  Branches        ?        0           
=======================================
  Hits            ?     1980           
  Misses          ?     8152           
  Partials        ?      224           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@biswassri
Copy link
Contributor

Looks good to me. Should I go ahead with an lgtm or do you want more folks to review?

@grdryn
Copy link
Member Author

grdryn commented Dec 18, 2024

@biswassri thanks! I think it's fine for you to leave an lgtm 👍

Copy link
Contributor

@biswassri biswassri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

openshift-ci bot commented Dec 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: biswassri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 9704854 into opendatahub-io:main Dec 18, 2024
10 checks passed
zdtsw pushed a commit to zdtsw-forking/opendatahub-operator that referenced this pull request Jan 2, 2025
@zdtsw zdtsw mentioned this pull request Jan 2, 2025
5 tasks
openshift-merge-bot bot pushed a commit that referenced this pull request Jan 2, 2025
* Removed IMAGE_OWNER from README.md. (#1444)

(cherry picked from commit 124b040)

* chore: update platform owners list (#1459)

(cherry picked from commit 9704854)

* chore: more updates owner list

Signed-off-by: Wen Zhou <wenzhou@redhat.com>

* (fix): change gha to target main (#1448)

(cherry picked from commit bc10dfc)

---------

Signed-off-by: Wen Zhou <wenzhou@redhat.com>
Co-authored-by: Ugo Giordano <ugiordan@redhat.com>
Co-authored-by: Gerard Ryan <git@grdryn.xyz>
Co-authored-by: Ajay Jaganathan <36824134+AjayJagan@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants