fix: bug not filling params.env with default cert value in model registry operator

[Al-Pragliola]

Description

Starting with version v2.22.0, the DEFAULT_CERT value in the params.env file for the model registry operator is not updated with the value from

	extraParamsMap = map[string]string{
		"DEFAULT_CERT": DefaultModelRegistryCert,
	}

The problem seems to be that the extraParamsMap was merged with imageParams when it was passed to the odhdeploy.ApplyParams function, here the second argument went through

	// 1. Update images with env variables
	// e.g "odh-kuberay-operator-controller-image": "RELATED_IMAGE_ODH_KUBERAY_OPERATOR_CONTROLLER_IMAGE",
	for i := range paramsEnvMap {
		relatedImageValue := os.Getenv(imageParamsMap[i])
		if relatedImageValue != "" {
			updated |= updateMap(&paramsEnvMap, i, relatedImageValue)
		}
	}

instead of

	// 2. Update other fileds with extraParamsMap which are not carried from component
	for _, extraParamsMap := range extraParamsMaps {
		for eKey, eValue := range extraParamsMap {
			updated |= updateMap(&paramsEnvMap, eKey, eValue)
		}
	}

so the empty value is explained

How Has This Been Tested?

local testing

Screenshot or short clip

envs from model registry operator

folder inside opendatahub-operator

Merge criteria

• You have read the contributors guide.
• Commit messages are meaningful - have a clear and concise summary and detailed explanation of what was changed and why.
• Pull Request contains a description of the solution, a link to the JIRA issue, and to any dependent or related Pull Request.
• Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
• The developer has manually tested the changes and verified that the changes work

[Al-Pragliola]

/cc @lburgazzoli @opendatahub-io/platform

[lburgazzoli]

@Al-Pragliola good catch, I guess other components may be suffering from the same issue ...

[Al-Pragliola]

@Al-Pragliola good catch, I guess other components may be suffering from the same issue ...

I looked at the other components and it seems that model registry was the only component affected

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lburgazzoli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [lburgazzoli]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[Al-Pragliola]

@lburgazzoli thanks for the review 🙏🏼 I think there's something wrong with the CI

[lburgazzoli]

@lburgazzoli thanks for the review 🙏🏼 I think there's something wrong with the CI

yep, it is broken

[biswassri]

/retest

[lburgazzoli]

/retest

[biswassri]

/retest

[lburgazzoli]

/retest

[lburgazzoli]

/retest

[lburgazzoli]

/test opendatahub-operator-e2e

[grdryn]

/retest

[biswassri]

/retest

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@dc23f27). Learn more about missing BASE report.

Files with missing lines	Patch %	Lines
...trollers/components/modelregistry/modelregistry.go	0.00%	2 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1457   +/-   ##
=======================================
  Coverage        ?   19.16%           
=======================================
  Files           ?      157           
  Lines           ?    10330           
  Branches        ?        0           
=======================================
  Hits            ?     1980           
  Misses          ?     8126           
  Partials        ?      224           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.