Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove WithDevFlags interface from PlatformObject since not every entity supports dev flags #1453

Merged
merged 1 commit into from
Dec 18, 2024
Merged

Remove WithDevFlags interface from PlatformObject since not every entity supports dev flags #1453

merged 1 commit into from
Dec 18, 2024

Conversation

lburgazzoli
Copy link
Contributor

Description

How Has This Been Tested?

Screenshot or short clip

Merge criteria

  • You have read the contributors guide.
  • Commit messages are meaningful - have a clear and concise summary and detailed explanation of what was changed and why.
  • Pull Request contains a description of the solution, a link to the JIRA issue, and to any dependent or related Pull Request.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@openshift-ci openshift-ci bot requested review from Sara4994 and zdtsw December 13, 2024 17:10
@lburgazzoli lburgazzoli requested review from StevenTobin and removed request for zdtsw and Sara4994 December 13, 2024 17:10
@lburgazzoli
Copy link
Contributor Author

lburgazzoli commented Dec 13, 2024 •
edited
Loading

@StevenTobin this may be useful to simplify the Auth CRD https://github.com/opendatahub-io/opendatahub-operator/pull/1452/files#diff-e12a0bcca721f3bd185c48c9524bdd2b4b38d7e3031de70d2b6549528b1ae075R66-R68

@lburgazzoli
Copy link
Contributor Author

/test opendatahub-operator-e2e

@codecov Codecov
Copy link

codecov bot commented Dec 14, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@dc23f27). Learn more about missing BASE report.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1453   +/-   ##
=======================================
  Coverage        ?   19.15%           
=======================================
  Files           ?      157           
  Lines           ?    10337           
  Branches        ?        0           
=======================================
  Hits            ?     1980           
  Misses          ?     8133           
  Partials        ?      224

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@StevenTobin
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Dec 16, 2024
biswassri
biswassri approved these changes Dec 16, 2024
View reviewed changes
Copy link
Contributor

@biswassri biswassri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[This PR doesn't have a description but I think the title explains it]

@openshift-ci openshift-ci bot removed the lgtm label Dec 16, 2024
@lburgazzoli
Copy link
Contributor Author

/retest

1 similar comment
@lburgazzoli
Copy link
Contributor Author

/retest

@openshift-ci openshift-ci bot added the lgtm label Dec 17, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Dec 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: biswassri, ykaliuta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lburgazzoli
Copy link
Contributor Author

/retest

5 similar comments
@lburgazzoli
Copy link
Contributor Author

/retest

@lburgazzoli
Copy link
Contributor Author

/retest

@lburgazzoli
Copy link
Contributor Author

/retest

@CFSNM
Copy link
Member

CFSNM commented Dec 17, 2024

/retest

@lburgazzoli
Copy link
Contributor Author

/retest

@lburgazzoli
Copy link
Contributor Author

/retest

@asanzgom
Copy link
Contributor

asanzgom commented Dec 17, 2024 •
edited
Loading

/retest-required

@lburgazzoli
Copy link
Contributor Author

/retest

7 similar comments
@biswassri
Copy link
Contributor

/retest

@MarianMacik
Copy link
Member

/retest

@lburgazzoli
Copy link
Contributor Author

/retest

@lburgazzoli
Copy link
Contributor Author

/retest

@biswassri
Copy link
Contributor

/retest

@lburgazzoli
Copy link
Contributor Author

/retest

@lburgazzoli
Copy link
Contributor Author

/retest

@openshift-merge-bot openshift-merge-bot bot merged commit 8e1b8f5 into opendatahub-io:main Dec 18, 2024
10 checks passed
@lburgazzoli lburgazzoli deleted the platform-object branch December 18, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@biswassri biswassri biswassri approved these changes

@ykaliuta ykaliuta ykaliuta approved these changes

@StevenTobin StevenTobin Awaiting requested review from StevenTobin

Assignees

@ykaliuta ykaliuta

@StevenTobin StevenTobin

@biswassri biswassri

Labels
approved feature-operator-refactor lgtm
Projects
ODH Platform Planning
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@lburgazzoli @StevenTobin @CFSNM @asanzgom @biswassri @MarianMacik @ykaliuta