Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make DSC's component conditions user friendly #1451

Merged
merged 3 commits into from
Dec 19, 2024
Merged

Make DSC's component conditions user friendly #1451

merged 3 commits into from
Dec 19, 2024

Conversation

lburgazzoli
Copy link
Contributor

@lburgazzoli lburgazzoli commented Dec 13, 2024 •
edited
Loading

Description

  • Make DSC's component conditions user friendly
  conditions:
  - lastHeartbeatTime: "2024-12-13T13:34:16Z"
    lastTransitionTime: "2024-12-13T13:33:58Z"
    message: Not Available
    reason: Unknown
    status: "False"
    type: CodeFlareReady
  - lastHeartbeatTime: "2024-12-13T13:34:16Z"
    lastTransitionTime: "2024-12-13T13:33:58Z"
    message: Component ManagementState is set to Removed
    reason: Removed
    status: "False"
    type: DashboardReady
  - lastHeartbeatTime: "2024-12-13T13:34:17Z"
    lastTransitionTime: "2024-12-13T13:33:59Z"
    message: Component ManagementState is set to Removed
    reason: Removed
    status: "False"
    type: KserveReady
  - lastHeartbeatTime: "2024-12-13T13:34:17Z"
    lastTransitionTime: "2024-12-13T13:33:59Z"
    message: Component ManagementState is set to Removed
    reason: Removed
    status: "False"
    type: KueueReady
  - lastHeartbeatTime: "2024-12-13T13:34:17Z"
    lastTransitionTime: "2024-12-13T13:33:59Z"
    message: Component ManagementState is set to Removed
    reason: Removed
    status: "False"
    type: ModelControllerReady
  - lastHeartbeatTime: "2024-12-13T13:34:17Z"
    lastTransitionTime: "2024-12-13T13:33:59Z"
    message: Component ManagementState is set to Removed
    reason: Removed
    status: "False"
    type: ModelMeshServingReady
  - lastHeartbeatTime: "2024-12-13T13:34:17Z"
    lastTransitionTime: "2024-12-13T13:33:59Z"
    message: Component ManagementState is set to Removed
    reason: Removed
    status: "False"
    type: ModelRegistryReady
  - lastHeartbeatTime: "2024-12-13T13:34:17Z"
    lastTransitionTime: "2024-12-13T13:33:59Z"
    message: Component ManagementState is set to Removed
    reason: Removed
    status: "False"
    type: RayReady
  - lastHeartbeatTime: "2024-12-13T13:34:17Z"
    lastTransitionTime: "2024-12-13T13:33:59Z"
    message: DataScienceCluster resource reconciled successfully
    reason: ReconcileCompleted
    status: "True"
    type: ReconcileComplete
  - lastHeartbeatTime: "2024-12-13T13:34:17Z"
    lastTransitionTime: "2024-12-13T13:33:59Z"
    message: Component ManagementState is set to Removed
    reason: Removed
    status: "False"
    type: TrainingOperatorReady
  - lastHeartbeatTime: "2024-12-13T13:34:17Z"
    lastTransitionTime: "2024-12-13T13:33:59Z"
    message: Component ManagementState is set to Removed
    reason: Removed
    status: "False"
    type: TrustyAIReady
  - lastHeartbeatTime: "2024-12-13T13:34:17Z"
    lastTransitionTime: "2024-12-13T13:33:59Z"
    message: Component ManagementState is set to Removed
    reason: Removed
    status: "False"
    type: WorkbenchesReady

Requires:

How Has This Been Tested?

e2e tests have been amended

Screenshot or short clip

Merge criteria

  • You have read the contributors guide.
  • Commit messages are meaningful - have a clear and concise summary and detailed explanation of what was changed and why.
  • Pull Request contains a description of the solution, a link to the JIRA issue, and to any dependent or related Pull Request.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Dec 13, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@lburgazzoli lburgazzoli changed the title cleanup components conditions Make DSC's component conditions user friendly Dec 13, 2024
@codecov Codecov
Copy link

codecov bot commented Dec 13, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@1b67705). Learn more about missing BASE report.

Files with missing lines Patch % Lines
controllers/components/codeflare/codeflare.go 0.00% 1 Missing ⚠️
controllers/components/dashboard/dashboard.go 0.00% 1 Missing ⚠️
...nents/datasciencepipelines/datasciencepipelines.go 0.00% 1 Missing ⚠️
controllers/components/kserve/kserve.go 0.00% 1 Missing ⚠️
controllers/components/kueue/kueue.go 0.00% 1 Missing ⚠️
...lers/components/modelcontroller/modelcontroller.go 0.00% 1 Missing ⚠️
...rs/components/modelmeshserving/modelmeshserving.go 0.00% 1 Missing ⚠️
...trollers/components/modelregistry/modelregistry.go 0.00% 1 Missing ⚠️
controllers/components/ray/ray.go 0.00% 1 Missing ⚠️
...rs/components/trainingoperator/trainingoperator.go 0.00% 1 Missing ⚠️
... and 2 more
Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1451   +/-   ##
=======================================
  Coverage        ?   19.12%           
=======================================
  Files           ?      158           
  Lines           ?    10355           
  Branches        ?        0           
=======================================
  Hits            ?     1980           
  Misses          ?     8151           
  Partials        ?      224

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lburgazzoli lburgazzoli force-pushed the cleanup-components-conditions branch from 53f165b to 618a6d8 Compare December 13, 2024 15:05
@lburgazzoli
Copy link
Contributor Author

/retest

@lburgazzoli
Make DSC's component conditions user friendly
8a2e6a1 
1. Use Components Kind as a prefix for the Ready condition so instead of
   having someting like odh-model-controllerReady we now have a more
   friendly ModeControllerReady
2. Make sure that the DVK defined in the gvk packages uses constants
   from components to avoid discrepancies
@lburgazzoli lburgazzoli force-pushed the cleanup-components-conditions branch from 618a6d8 to 8a2e6a1 Compare December 18, 2024 08:45
@lburgazzoli lburgazzoli marked this pull request as ready for review December 18, 2024 08:45
@lburgazzoli
Copy link
Contributor Author

/retest

@lburgazzoli
Copy link
Contributor Author

/test opendatahub-operator-e2e

4 similar comments
@lburgazzoli
Copy link
Contributor Author

/test opendatahub-operator-e2e

@lburgazzoli
Copy link
Contributor Author

/test opendatahub-operator-e2e

@lburgazzoli
Copy link
Contributor Author

/test opendatahub-operator-e2e

@lburgazzoli
Copy link
Contributor Author

/test opendatahub-operator-e2e

@lburgazzoli lburgazzoli requested review from grdryn and removed request for gzaronikas December 19, 2024 14:09
grdryn
grdryn approved these changes Dec 19, 2024
View reviewed changes
Copy link
Member

@grdryn grdryn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm 🚀

@openshift-ci openshift-ci bot added the lgtm label Dec 19, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Dec 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: grdryn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit c31a85b into opendatahub-io:main Dec 19, 2024
8 checks passed
@lburgazzoli lburgazzoli deleted the cleanup-components-conditions branch December 19, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grdryn grdryn grdryn approved these changes

@ugiordan ugiordan Awaiting requested review from ugiordan

Assignees

@grdryn grdryn

Labels
approved feature-operator-refactor lgtm
Projects
ODH Platform Planning
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lburgazzoli @grdryn @openshift-merge-robot