(fix): change gha to target main #1448
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1448 +/- ##
=======================================
Coverage ? 19.09%
=======================================
Files ? 149
Lines ? 10370
Branches ? 0
=======================================
Hits ? 1980
Misses ? 8166
Partials ? 224 ☔ View full report in Codecov by Sentry. |
|
this looks good to me, but I'll let @VaishnaviHire review |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: asanzgom The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
| git fetch origin incubation:incubation | ||
| git checkout incubation | ||
| git fetch origin main:main | ||
| git checkout main | ||
| git checkout -b odh-${{ env.VERSION }} | ||
| git push -f origin odh-${{ env.VERSION }} |
There was a problem hiding this comment.
Unrelated to the patch, but if intention is to make a copy of the branch in the remote, it may be a bit simplified as git fetch origin main; git push origin FETCH_HEAD:refs/heads/odh-${{ env.VERSION }}
Can the branch name somehow be parametrized?
The PR itself looks good to me
There was a problem hiding this comment.
yes it could be done. I can do that in a separate pr. Thanks for the idea @ykaliuta
openshift-merge-bot
bot
merged commit bc10dfc
into
opendatahub-io:main
(cherry picked from commit bc10dfc)
* Removed IMAGE_OWNER from README.md. (#1444) (cherry picked from commit 124b040) * chore: update platform owners list (#1459) (cherry picked from commit 9704854) * chore: more updates owner list Signed-off-by: Wen Zhou <wenzhou@redhat.com> * (fix): change gha to target main (#1448) (cherry picked from commit bc10dfc) --------- Signed-off-by: Wen Zhou <wenzhou@redhat.com> Co-authored-by: Ugo Giordano <ugiordan@redhat.com> Co-authored-by: Gerard Ryan <git@grdryn.xyz> Co-authored-by: Ajay Jaganathan <36824134+AjayJagan@users.noreply.github.com>
Description
Change the GH actions for release process to target main branch.
How Has This Been Tested?
Screenshot or short clip
Merge criteria