Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update: add missing permissions #1391

Closed

Conversation

zdtsw
Copy link
Member

@zdtsw zdtsw commented Nov 26, 2024

  • some error that kueue, dashboard, TO cannot list resources
  • some are listed in the DSCI but missing verb, put each explictliy in components, so we do not rely on DSCI if we move monitoring into service

Description

How Has This Been Tested?

Screenshot or short clip

Merge criteria

  • You have read the contributors guide.
  • Commit messages are meaningful - have a clear and concise summary and detailed explanation of what was changed and why.
  • Pull Request contains a description of the solution, a link to the JIRA issue, and to any dependent or related Pull Request.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@zdtsw zdtsw requested a review from lburgazzoli November 26, 2024 09:48
@openshift-ci openshift-ci bot requested a review from gzaronikas November 26, 2024 09:48
Copy link

openshift-ci bot commented Nov 26, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from zdtsw. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

- some error that kueue, dashboard, TO cannot list resources

Signed-off-by: Wen Zhou <wenzhou@redhat.com>
@zdtsw zdtsw marked this pull request as draft November 26, 2024 09:57
@zdtsw zdtsw removed the request for review from gzaronikas November 26, 2024 09:57
@zdtsw zdtsw closed this Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant