fix: missing comopnent init step for Ray in main #1331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zdtsw
requested review from
lburgazzoli
and removed request for
StevenTobin and
jackdelahunt
lburgazzoli
reviewed
Oct 31, 2024
main.go
Outdated
| if err := rayctrl.Init(p); err != nil { | ||
| multiErr = multierror.Append(multiErr, err) | ||
| } | ||
| return multiErr |
There was a problem hiding this comment.
maybe use ErrorOrNil() here so it is consistent with the standard error pattern
Signed-off-by: Wen Zhou <wenzhou@redhat.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: VaishnaviHire The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature-operator-refactor #1331 +/- ##
============================================================
Coverage ? 24.54%
============================================================
Files ? 52
Lines ? 4273
Branches ? 0
============================================================
Hits ? 1049
Misses ? 3095
Partials ? 129 ☔ View full report in Codecov by Sentry. |
openshift-merge-bot
bot
merged commit f3fa346
into
opendatahub-io:feature-operator-refactor
10 checks passed
This was referenced Dec 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
How Has This Been Tested?
Screenshot or short clip
Merge criteria