Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHOAIENG-11709: Adding a release github action #32

Merged
merged 4 commits into from
Sep 17, 2024

Conversation

etirelli
Copy link

@etirelli etirelli commented Sep 10, 2024

In order to publish the elyra packages to pypi, push a tag with the format v<version> to the repository.

Fixes: https://issues.redhat.com/browse/RHOAIENG-11709

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm on the setup
The token needs to be gather and included.
Tested a dry-run; https://github.com/harshad16/elyra/actions/runs/10800742648/job/29959417327

Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trusted published is set on the pypi,
https://docs.pypi.org/trusted-publishers/adding-a-publisher/
we are all set for this project.

Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some changes:

.github/workflows/release.yml Outdated Show resolved Hide resolved
.github/workflows/release.yml Show resolved Hide resolved
etirelli and others added 2 commits September 11, 2024 07:59
Co-authored-by: Harshad Reddy Nalla <harshadreddy16@gmail.com>
@etirelli etirelli changed the title [WIP - do not merge] Adding a release github action Adding a release github action Sep 13, 2024
@etirelli etirelli changed the title Adding a release github action RHOAIENG-11709: Adding a release github action Sep 13, 2024
@caponetto caponetto requested a review from harshad16 September 16, 2024 18:50
Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@harshad16 harshad16 merged commit 0343ad8 into opendatahub-io:jupyterlab4 Sep 17, 2024
16 checks passed
paulovmr pushed a commit that referenced this pull request Sep 26, 2024
* Adding github action for elyra releases

* Adding release github action

* Apply suggestions from code review

* Updating release action to fix minor bug

---------
Co-authored-by: Harshad Reddy Nalla <harshadreddy16@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants