Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve reason to skip tests #29

Merged
merged 1 commit into from
Aug 28, 2024
Merged

Improve reason to skip tests #29

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions elyra/tests/cli/test_pipeline_app.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1080,7 +1080,7 @@ def test_export_incompatible_runtime_config(kubeflow_pipelines_runtime_instance,

@pytest.mark.parametrize("catalog_instance_no_server_process", [KFP_COMPONENT_CACHE_INSTANCE], indirect=True)
@pytest.mark.skip(
reason="This test is not compatible with KFP v2: It relies on incompatible assets from elyra-examples-kfp-catalog lib. See https://github.com/elyra-ai/examples/issues/115" # noqa: E501
reason="This test is not compatible with KFP v2: It relies on incompatible assets from elyra-examples-kfp-catalog lib. See https://github.com/elyra-ai/examples/issues/115 and https://github.com/opendatahub-io/elyra-examples/pull/1" # noqa: E501
)
def test_export_kubeflow_output_option(
jp_environ, kubeflow_pipelines_runtime_instance, catalog_instance_no_server_process
Expand Down Expand Up @@ -1233,7 +1233,7 @@ def test_export_airflow_output_option(airflow_runtime_instance):

@pytest.mark.parametrize("catalog_instance_no_server_process", [KFP_COMPONENT_CACHE_INSTANCE], indirect=True)
@pytest.mark.skip(
reason="This test is not compatible with KFP v2: It relies on incompatible assets from elyra-examples-kfp-catalog lib. See https://github.com/elyra-ai/examples/issues/115" # noqa: E501
reason="This test is not compatible with KFP v2: It relies on incompatible assets from elyra-examples-kfp-catalog lib. See https://github.com/elyra-ai/examples/issues/115 and https://github.com/opendatahub-io/elyra-examples/pull/1" # noqa: E501
)
def test_export_kubeflow_overwrite_option(
jp_environ, kubeflow_pipelines_runtime_instance, catalog_instance_no_server_process
Expand Down Expand Up @@ -1329,7 +1329,7 @@ def test_export_airflow_format_option(airflow_runtime_instance):

@pytest.mark.parametrize("catalog_instance_no_server_process", [KFP_COMPONENT_CACHE_INSTANCE], indirect=True)
@pytest.mark.skip(
reason="This test is not compatible with KFP v2: It relies on incompatible assets from elyra-examples-kfp-catalog lib. See https://github.com/elyra-ai/examples/issues/115" # noqa: E501
reason="This test is not compatible with KFP v2: It relies on incompatible assets from elyra-examples-kfp-catalog lib. See https://github.com/elyra-ai/examples/issues/115 and https://github.com/opendatahub-io/elyra-examples/pull/1" # noqa: E501
)
def test_export_kubeflow_format_option(
jp_environ, kubeflow_pipelines_runtime_instance, catalog_instance_no_server_process
Expand Down
Loading