-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for builds on mac+podman #22
Conversation
with regards to bootstrapper.py and logging, check this out upstream: env variable either in runtime image or in global or per pipeline node env values: steering whether .log files are written to s3 or not. with regards to podman builds on arm / Mac Mx and python: opendatahub-io-contrib/workbench-images#56 (comment) @etirelli regarding what you did in this PR for logging script output correctly and not necessarily putting the .log output to S3: I added a new kfp bootstrapper.py upstream and documentation specifically for that issue with the .log file output to S3 vs logging script output to STDOUT only. https://github.com/elyra-ai/elyra/blob/main/docs/source/user_guide/env-variables-file-based-nodes.md https://github.com/elyra-ai/elyra/blob/main/elyra/kfp/bootstrapper.py#L51 https://github.com/elyra-ai/elyra/blob/main/elyra/kfp/bootstrapper.py#L502 |
@shalberd thank you for the suggestion. However, without the changes from this PR, even when using --arch option, the build fails on my mac. Since these changes only affect the image used for local development (inner loop), I would like to eventually merge them (or an equivalent fix) into the codebase. |
I was looking into the CI error on
The import has been changed on #1 from Consider that the latest
Although So if you run
This is the same result that you see on the Note that, since |
@harshad16 is what @caponetto writes regarding CI tests relevant for a follow-up PR? And, of course interesting for me, will the changes related to Jupyterlab v4 support and KFP v2 make it into upstream elyra? |
* applying changes to build the dev image for mac * applying changes to build the dev image for mac * Updating Dockerfile to compile elyra on mac * implementing changes for the build process to work on a mac + podman * implementing changes for the build process to work on a mac + podman * Fixing dockerfile to work on mac * implementing changes for the build process to work on a mac + podman * Fixing dockerfile to work on mac * fixing linter * Upgrading to Node 20 * Undoing yarn.lock change --------- Co-authored-by: Eder Ignatowicz <ignatowicz@gmail.com>
This PR adds changes to support building the project on MacOS + podman.
Developer's Certificate of Origin 1.1