Farajaland form updates #805
Conversation
tahmidrahman-dsi
commented
Dec 5, 2023
•
tahmidrahman-dsi
commented
- Add a custom field to Farajaland death form #6203
- Add Proof of identity document select to Farajaland forms#6202
- Add a Spouse page to the Farajaland death form#6204
src/form/birth/index.ts
Outdated
| getIDType( | ||
| 'birth', | ||
| 'informant', | ||
| hideIfNidIntegrationEnabled.concat(detailsExist), |
There was a problem hiding this comment.
detailsExist doesn't apply to informant so we need hideIfInformantMotherOrFather instead
There was a problem hiding this comment.
Good catch @Zangetsu101 I am going to correct that
src/form/custom-fields.ts
Outdated
| return { | ||
| name: fieldName, | ||
| required, | ||
| custom: true, |
There was a problem hiding this comment.
Do we need this field to be a custom one? If not then as it's a default field that we support, we need to add it as a valid optional field here: https://github.com/opencrvs/opencrvs-core/blob/develop/packages/config/src/handlers/forms/validation.ts#L228
There was a problem hiding this comment.
Thanks @Zangetsu101, I don't think it needs to be a custom one, but rather an optional field. I am on it
src/form/death/index.ts
Outdated
| spouseDetailsExistConditionals*/, | ||
| spouseDetailsExistConditionals, |
There was a problem hiding this comment.
Could we clean up the imports here a bit please?
src/form/death/index.ts
Outdated
| spouseNameInEnglish*/, | ||
| spouseNameInEnglish |
|
Euan to discuss if this should be cherry-picked on top of 1.3.3 |
|
@tahmidrahman-dsi Apologies as I don't think we can make the id fields non-custom (i.e. optional fields) as this would restrict us on the types of field we can support, so let's revert that change I requested previously |
|
@tahmidrahman-dsi we have decided to put this into 1.3.3. Can you make a new PR based on the release-v1.3.3 branch and cherry-pick these commits onto it and re-submit this PR please? |
tahmidrahman-dsi
force-pushed
the
ocrvs-6202-6203-6204
branch
from
045d9fb to
bd56087
Compare
tahmidrahman-dsi
force-pushed
the
ocrvs-6202-6203-6204
branch
from
a84048c to
e9399f4
Compare
