Skip to content

Commit

Permalink
ocrvs-6204 fix date of birth unknown checkbox conditional & update CH…
Browse files Browse the repository at this point in the history
…ANGELOG (#898)

* Consider detailsExist conditional when age unknown

* Update CHANGELOG
  • Loading branch information
Zangetsu101 authored Feb 20, 2024
1 parent 9a98750 commit 68c02c4
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 6 deletions.
10 changes: 10 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,16 @@
##### We will be deprecating the counterpart of the above mentioned handlebars that contains only the label of the specified location in a future version so we highly recommend that implementers update their certificates to use these new ones.
- #### "Spouse" section in Farajaland death form
Spouse section is an optional section in death form. Going forward it will be included in Farajaland example configuration.
- #### Type of ID dropdown
Farajaland forms will now include a dropdown to select the type of ID an individual is providing e.g. National ID, Driving License etc. instead of being restricted to only national ID number.
- #### Number of dependents of deceased field
As an example of custom field, the deceased section in death form will now include the __numberOfDependants__ field.
- #### Reason for late registration field
The birth & death forms will include another custom field, __reasonForLateRegistration__, which makes use of "LATE_REGISTRATION_TARGET" configuration option in it's visibility conditional.
## Bug fixes
- Updated translations for form introduction page and sending for approval to reflect the default notification method being email.
Expand Down
8 changes: 2 additions & 6 deletions src/form/death/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -46,16 +46,12 @@ import {
informantFirstNameConditionals,
exactDateOfBirthUnknownConditional,
isValidBirthDate /*,
spouseFirstNameConditionals,
spouseFamilyNameConditionals,
spouseBirthDateConditionals,
fathersDetailsExistConditionals,
fatherFirstNameConditionals,
fatherFamilyNameConditionals,
fathersBirthDateConditionals,
parentsBirthDateValidators,
detailsExistConditional,
detailsExist,
motherFirstNameConditionals,
motherFamilyNameConditionals,
mothersBirthDateConditionals,
Expand Down Expand Up @@ -351,10 +347,10 @@ export const deathForm = {
],
certificateHandlebars.spouseBirthDate
), // Required field.
exactDateOfBirthUnknown([]),
exactDateOfBirthUnknown(detailsExist),
getAgeOfIndividualInYears(
formMessageDescriptors.ageOfSpouse,
exactDateOfBirthUnknownConditional,
exactDateOfBirthUnknownConditional.concat(detailsExist),
ageOfIndividualValidators
),
getNationality(
Expand Down

0 comments on commit 68c02c4

Please sign in to comment.