Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

As a user I want to select a template to issue a certified copy with #290

Merged
merged 37 commits into from
Dec 26, 2024
Merged

As a user I want to select a template to issue a certified copy with #290

merged 37 commits into from
Dec 26, 2024

Conversation

tareq89
Copy link
Collaborator

@tareq89 tareq89 commented Oct 3, 2024

@tareq89 tareq89 self-assigned this Oct 3, 2024
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@tareq89 tareq89 changed the title Ocrvs 7584 As a user I want to select a template to issue a certified copy with Oct 4, 2024
rikukissa
rikukissa reviewed Oct 23, 2024
View reviewed changes
src/form/types/types.ts Outdated Show resolved Hide resolved
@tareq89 tareq89 marked this pull request as ready for review October 29, 2024 15:37
@tareq89 tareq89 requested a review from rikukissa October 29, 2024 15:37
@tareq89 tareq89 added this to the v1.7.0 milestone Oct 29, 2024
rikukissa
rikukissa reviewed Oct 31, 2024
View reviewed changes
src/index.ts Outdated Show resolved Hide resolved
rikukissa
rikukissa reviewed Nov 1, 2024
View reviewed changes
src/index.ts Outdated Show resolved Hide resolved
@tareq89 tareq89 force-pushed the ocrvs-7584 branch 2 times, most recently from 2ec55a2 to 082d472 Compare November 6, 2024 10:50
@rikukissa rikukissa mentioned this pull request Nov 12, 2024
Merged
tareq89 and others added 15 commits November 27, 2024 14:38
@euanmillar euanmillar mentioned this pull request Dec 10, 2024
Open
6 tasks
Zangetsu101
Zangetsu101 previously requested changes Dec 26, 2024
View reviewed changes
Copy link
Collaborator

@Zangetsu101 Zangetsu101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we please remove the certificate templates that are not being uses? I noticed a couple still being left

@tareq89 tareq89 dismissed Zangetsu101’s stale review December 26, 2024 07:53

unused templates removed

@tareq89 tareq89 merged commit 93294a7 into develop Dec 26, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rikukissa rikukissa rikukissa approved these changes

@Zangetsu101 Zangetsu101 Zangetsu101 left review comments

@euanmillar euanmillar Awaiting requested review from euanmillar

@Nil20 Nil20 Awaiting requested review from Nil20

Assignees

@tareq89 tareq89

Labels
None yet
Projects
None yet
Milestone
v1.7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@tareq89 @rikukissa @Zangetsu101