Feat/ocrvs 7978/qr reader #1
Conversation
tahmidrahman-dsi
commented
Dec 18, 2024
•
tahmidrahman-dsi
commented
tahmidrahman-dsi
force-pushed
the
feat/ocrvs-7978/qr-reader
branch
from
fbfdfd3 to
385bcfe
Compare
This comment has been minimized.
This comment has been minimized.
src/form/birth/index.ts
Outdated
| @@ -219,20 +220,68 @@ export const birthForm: ISerializedForm = { | |||
| fields: [ | |||
| informantType, // Required field. | |||
| otherInformantType(Event.Birth), // Required field. | |||
| getIDReaderField( | |||
There was a problem hiding this comment.
@tahmidrahman-dsi I thought that we would apply these functions using functions from here: opencrvs/mosip#26. Do we have to merge that one in first?
There was a problem hiding this comment.
Yes @euanmillar eventually we will import these from @opencrvs/mosip. please feel free to merge if the changes look okay. After the changes are published, I can import these functions here
There was a problem hiding this comment.
@tahmidrahman-dsi I spoke with Pyry, and we are going to publish multiple versions so can you close this PR and instead copy over the appropriate form changes to https://github.com/opencrvs/mosip then we can merge in and use the form functions properly in this repo. Please note the latest WIP changes I merged in that repo. Will set up a call with you to discuss how to send the draft id, e.g. $. from the REDIRECT button. Can you apply any updates to the functions I created with Pathum as I gather you have renamed it LINK_BUTTON now if thats correct?
There was a problem hiding this comment.
Yes that's correct. The update should be in mosip repo as well
…mosip into feat/ocrvs-7978/qr-reader
…into qr-reader-with-latest-develop
Update qr-reader branch with latest develop
src/form/birth/index.ts
Outdated
| { | ||
| name: 'verified', | ||
| type: 'HIDDEN', | ||
| custom: true, | ||
| label: { | ||
| id: 'messages.empty', | ||
| defaultMessage: '' | ||
| }, | ||
| validator: [] | ||
| }, | ||
| { | ||
| name: 'idPending', | ||
| type: 'ID_VERIFICATION_BANNER', | ||
| custom: true, | ||
| bannerType: 'pending', | ||
| idFieldName: 'idReader', | ||
| label: { | ||
| id: 'messages.empty', | ||
| defaultMessage: '' | ||
| }, | ||
| validator: [], | ||
| conditionals: [ | ||
| { | ||
| action: 'hide', | ||
| expression: '$form?.verified !== "pending"' | ||
| } | ||
| ] | ||
| }, |
There was a problem hiding this comment.
@naftis these are the recent changes
…mosip into feat/ocrvs-7978/qr-reader
There was a problem hiding this comment.
Can we only merge this after we can import the form fields from @opencrvs/mosip to keep the git history a bit cleaner to avoid conflicts with opencrvs-countryconfig. What do you think @tahmidrahman-dsi
src/form/birth/custom-fields.ts
Outdated
| defaultMessage: 'E-signet' | ||
| }, | ||
| options: { | ||
| url: 'https://docs.esignet.io/', |
There was a problem hiding this comment.
@tahmidrahman-dsi Regarding Euan's question, can we use something like $draft.id here?
|
@tahmidrahman-dsi now that this is merged, can we now amend the form config to use the module functions? |
Yes, I am on it |
…rvs-countryconfig-mosip into feat/ocrvs-7978/qr-reader
| - OPENID_PROVIDER_CLIENT_ID=${OPENID_PROVIDER_CLIENT_ID} | ||
| - OPENID_PROVIDER_CLAIMS=${OPENID_PROVIDER_CLAIMS} | ||
| - OIDP_USER_INFO_URL=${OIDP_USER_INFO_URL} | ||
| - LOCALE=en |
There was a problem hiding this comment.
@naftis I would like this LOCALE env var available to the server package used in this PR: opencrvs/mosip#31. How should we set up docker-compose config for this?
|
@tahmidrahman-dsi I pushed a couple of commits which I think will tie this together if this PR is also OK and merged? |
