Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Events v2: only return user's own drafts as part of event #8303

Merged
merged 8 commits into from
Jan 9, 2025

Conversation

rikukissa
Copy link
Member

@rikukissa rikukissa commented Jan 8, 2025

This makes me think we need to give these drafts a bit more thought:

  • In the current "legacy events" you can create a local draft at any point in the process. So even after it's declared or validated. This is as part of whatever process you are completing at the time.
  • Should we actually make it so that there is no DRAFT action but rather any action can have draft: true?

@rikukissa rikukissa requested a review from makelicious January 8, 2025 06:40
Copy link

github-actions bot commented Jan 8, 2025

Oops! Looks like you forgot to update the changelog. When updating CHANGELOG.md, please consider the following:

  • Changelog is read by country implementors who might not always be familiar with all technical details of OpenCRVS. Keep language high-level, user friendly and avoid technical references to internals.
  • Answer "What's new?", "Why was the change made?" and "Why should I care?" for each change.
  • If it's a breaking change, include a migration guide answering "What do I need to do to upgrade?".

Copy link
Collaborator

@makelicious makelicious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Let's update test cases to capture the requirement

@rikukissa rikukissa merged commit c3d3d28 into develop Jan 9, 2025
37 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants