Events v2: Implement optimistic file upload and FILE type input #8246

rikukissa · 2024-12-18T14:04:18Z

opencrvs/opencrvs-countryconfig#348

…ts-v2-file-input

github-actions · 2024-12-18T15:41:38Z

Oops! Looks like you forgot to update the changelog. When updating CHANGELOG.md, please consider the following:

Changelog is read by country implementors who might not always be familiar with all technical details of OpenCRVS. Keep language high-level, user friendly and avoid technical references to internals.
Answer "What's new?", "Why was the change made?" and "Why should I care?" for each change.
If it's a breaking change, include a migration guide answering "What do I need to do to upgrade?".

makelicious · 2024-12-18T16:19:46Z

Seems to break down:

makelicious · 2024-12-18T16:20:10Z

Fixed some types as requested

naftis · 2024-12-19T00:49:22Z

packages/client/src/v2-events/components/forms/FormFieldGenerator.tsx

+const FIELD_SEPARATOR = '____'
+function unflatten<T>(data: Record<string, T>) {
+  return Object.fromEntries(
+    Object.entries(data).map(([key, value]) => [
+      key.replaceAll('.', FIELD_SEPARATOR),
+      value
+    ])
+  )
+}
+
+function flatten<T>(data: Record<string, T>) {
+  return Object.fromEntries(
+    Object.entries(data).map(([key, value]) => [
+      key.replaceAll(FIELD_SEPARATOR, '.'),
+      value
+    ])
+  )
+}


Let's document this very carefully why we do this, it's so annoying :(

makelicious

Some stylistic comments. Will continue soon!

makelicious · 2024-12-19T07:43:00Z

packages/client/src/v2-events/components/forms/inputs/FileInput/FileInput.tsx

+      allowedDocType={allowedDocType}
+      description={description}
+      error={''}
+      file={file ? file : undefined}


I understand that null is easier for browser default, could we have either undefined or null

👍 Good point. I changed the default now to be undefined. Was first changing it to null but remembered I wanted to keep "null" as an explicit empty value in the form field generator and undefined more a "this field is not defined (yet)", so went with undefined here as well

makelicious · 2024-12-19T07:43:44Z

packages/client/src/v2-events/components/forms/inputs/FileInput/FileInput.tsx

+      description={description}
+      error={''}
+      file={file ? file : undefined}
+      label={file ? file.originalFilename : ''}


Could we generate a label or make it optional, passing empty strings along the line will contain surprises in the end

Changed this to just be undefined or a real label

makelicious · 2024-12-19T07:44:06Z

packages/client/src/v2-events/components/forms/inputs/FileInput/FileInput.tsx

+          uploadFiles(newFile)
+        } else {
+          setFile(null)
+          onChange(undefined)


might be a matter of taste, but could be left out

setFile needs to want the value to be explicitly set 🤔 Maybe best to have both the same way so explicit?

makelicious · 2024-12-19T07:44:52Z

packages/client/src/v2-events/components/forms/inputs/FileInput/SimpleDocumentUploader.tsx

+  requiredErrorMessage,
+  touched
+}: IFullProps) {
+  const [error, setError] = useState('')


We could just use undefined value

Yea, this was some og code brought back from the core side. Don't want to touch it quite yet

makelicious · 2024-12-19T07:47:20Z

packages/client/src/v2-events/features/events/components/Preview.tsx

+    return <></>
+  }
+
+  return <>{value.toString() || ''}</>


will the fallback ever trigger?

Yea probably doesn't anymore 👍

makelicious

Looks good!

…ts-v2-file-input

…lected file

…ore into events-v2-file-input

…ts-v2-file-input

implement optimistic file upload and FILE type input

edbe07a

rikukissa requested a review from makelicious December 18, 2024 14:04

rikukissa added 3 commits December 18, 2024 16:20

Merge branch 'develop' of github.com:opencrvs/opencrvs-core into even…

8593948

…ts-v2-file-input

fix broken offline record creation

6df0b40

fix one type error

03d7be3

makelicious added 2 commits December 18, 2024 18:07

fix: update tests, add missing license header

1ea0f11

fix: explicitly throw if cache not found

7b0d269

naftis reviewed Dec 19, 2024

View reviewed changes

rikukissa added 3 commits December 19, 2024 06:38

fix type errors

45a9879

fix eslint errors

61c7c75

fix review page

45dab8e

makelicious reviewed Dec 19, 2024

View reviewed changes

makelicious approved these changes Dec 19, 2024

View reviewed changes

add signing for files fetched from events service

78f2056

rikukissa added the 🚀 Ready to deploy Deployment automation should pick this PR up and start auto-deploying it label Dec 19, 2024

Merge branch 'develop' of github.com:opencrvs/opencrvs-core into even…

3ed265f

…ts-v2-file-input

rikukissa temporarily deployed to events-v2-file-input December 19, 2024 10:44 — with GitHub Actions Inactive

cleanup

1561e2e

rikukissa temporarily deployed to events-v2-file-input December 19, 2024 10:49 — with GitHub Actions Inactive

rikukissa added 2 commits December 19, 2024 12:50

cleanup

981a6f0

use undefined instead of null in FileInput as the default value of se…

434293b

…lected file

rikukissa temporarily deployed to events-v2-file-input December 19, 2024 10:55 — with GitHub Actions Inactive

remove default empty string value

157cc71

rikukissa temporarily deployed to events-v2-file-input December 19, 2024 10:58 — with GitHub Actions Inactive

remove fallback output

f850846

rikukissa temporarily deployed to events-v2-file-input December 19, 2024 11:02 — with GitHub Actions Inactive

fix linter error

afc741a

rikukissa and others added 4 commits December 20, 2024 10:03

move debugger to top level of events v2

125c78d

Merge branch 'events-v2-file-input' of github.com:opencrvs/opencrvs-c…

f1f3527

…ore into events-v2-file-input

fix: add mock for files service call

a6ad8f0

chore: add msw, mock documents api call

a58902d

makelicious temporarily deployed to events-v2-file-input December 20, 2024 09:19 — with GitHub Actions Inactive

fix: add missing license header

425bcef

makelicious temporarily deployed to events-v2-file-input December 20, 2024 09:21 — with GitHub Actions Inactive

rikukissa added 2 commits December 20, 2024 11:47

refactor react query logic a bit

dfea202

Merge branch 'events-v2-file-input' of github.com:opencrvs/opencrvs-c…

3f2adc8

…ore into events-v2-file-input

rikukissa temporarily deployed to events-v2-file-input December 20, 2024 09:48 — with GitHub Actions Inactive

fix: remove unused export

048c7a6

makelicious temporarily deployed to events-v2-file-input December 20, 2024 09:57 — with GitHub Actions Inactive

fix: change cache invalidation order

02550e7

makelicious temporarily deployed to events-v2-file-input December 20, 2024 15:00 — with GitHub Actions Inactive

Merge branch 'develop' into events-v2-file-input

c74bd85

makelicious temporarily deployed to events-v2-file-input December 20, 2024 15:02 — with GitHub Actions Inactive

fix: add flushPromises

9a46b31

makelicious temporarily deployed to events-v2-file-input December 20, 2024 15:53 — with GitHub Actions Inactive

fix: add flushPromises to top-level

095b2a1

makelicious temporarily deployed to events-v2-file-input December 20, 2024 16:16 — with GitHub Actions Inactive

Merge branch 'develop' of github.com:opencrvs/opencrvs-core into even…

6d5a048

…ts-v2-file-input

rikukissa temporarily deployed to events-v2-file-input January 3, 2025 05:25 — with GitHub Actions Inactive

fix merge

3958a5c

rikukissa temporarily deployed to events-v2-file-input January 3, 2025 05:54 — with GitHub Actions Inactive

add types back

65abcd5

rikukissa temporarily deployed to events-v2-file-input January 3, 2025 05:57 — with GitHub Actions Inactive

improve knip diff output

6a54760

rikukissa temporarily deployed to events-v2-file-input January 3, 2025 06:20 — with GitHub Actions Inactive

rikukissa deployed to events-v2-file-input January 3, 2025 06:48 — with GitHub Actions Active

rikukissa merged commit 1acab85 into develop Jan 3, 2025
64 of 65 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Events v2: Implement optimistic file upload and FILE type input #8246

Events v2: Implement optimistic file upload and FILE type input #8246

rikukissa commented Dec 18, 2024 •

edited

Loading

github-actions bot commented Dec 18, 2024

makelicious commented Dec 18, 2024

makelicious commented Dec 18, 2024

naftis Dec 19, 2024

rikukissa Dec 19, 2024

makelicious left a comment

makelicious Dec 19, 2024

rikukissa Dec 19, 2024

makelicious Dec 19, 2024

rikukissa Dec 19, 2024

makelicious Dec 19, 2024

rikukissa Dec 19, 2024

makelicious Dec 19, 2024

rikukissa Dec 19, 2024

makelicious Dec 19, 2024

rikukissa Dec 19, 2024

makelicious left a comment

Events v2: Implement optimistic file upload and FILE type input #8246

Events v2: Implement optimistic file upload and FILE type input #8246

Conversation

rikukissa commented Dec 18, 2024 • edited Loading

github-actions bot commented Dec 18, 2024

makelicious commented Dec 18, 2024

makelicious commented Dec 18, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

makelicious left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

makelicious left a comment

Choose a reason for hiding this comment

rikukissa commented Dec 18, 2024 •

edited

Loading