Chore/create test boilerplate for events #8236

makelicious · 2024-12-17T13:09:13Z

github-actions · 2024-12-17T13:09:27Z

Oops! Looks like you forgot to update the changelog. When updating CHANGELOG.md, please consider the following:

Changelog is read by country implementors who might not always be familiar with all technical details of OpenCRVS. Keep language high-level, user friendly and avoid technical references to internals.
Answer "What's new?", "Why was the change made?" and "Why should I care?" for each change.
If it's a breaking change, include a migration guide answering "What do I need to do to upgrade?".

jamil314 · 2024-12-18T12:10:23Z

packages/events/src/router/events.get.test.ts

+})
+
+test('Returns multiple events', async () => {
+  for await (const _ of Array(10).keys()) {


Suggested change

for await (const _ of Array(10).keys()) {

for (let i = 0; i < 10; i++) {

jamil314 · 2024-12-18T12:11:04Z

packages/events/src/service/indexing/indexing.test.ts

  const esClient = getOrCreateClient()

  await indexAllEvents()

+  for await (const _ of Array(2).keys()) {


Suggested change

for await (const _ of Array(2).keys()) {

for (let i = 0; i < 2; i++) {

makelicious added 2 commits December 17, 2024 15:07

chore: create test boilerplate for events

8b5ce8b

Merge branch 'develop' into chrore/create-test-boilerplate-for-events

96704ee

makelicious requested review from rikukissa and jamil314 December 17, 2024 13:09

makelicious added 4 commits December 17, 2024 15:10

fix: add missing license headers

7790762

fix: relative imports

f6179e2

fix: pass client as string to avoid indexdb error

58d4933

fix: add flushPromises on beforeEach

112b049

makelicious force-pushed the chrore/create-test-boilerplate-for-events branch from 1905d95 to 112b049 Compare December 17, 2024 15:19

makelicious added 4 commits December 18, 2024 08:54

Merge branch 'develop' into chrore/create-test-boilerplate-for-events

6e839da

fix: add flushPromises to all declarationForm tests

68b3b37

fix: stringify client to avoid idb error

345fb63

fix: reset ESServer before creating test items

1893583

jamil314 approved these changes Dec 18, 2024

View reviewed changes

makelicious and others added 3 commits December 18, 2024 14:43

fix: use simple for as suggested

5084029

fix: add flushPromises to all SelectVitalEvent tests

53f85ba

Merge branch 'develop' into chrore/create-test-boilerplate-for-events

bc26f64

makelicious merged commit 37b84cc into develop Dec 18, 2024
31 of 32 checks passed

Provide feedback

	for await (const _ of Array(10).keys()) {
	for (let i = 0; i < 10; i++) {

	for await (const _ of Array(2).keys()) {
	for (let i = 0; i < 2; i++) {