Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow supplying a comment with confirmRegistration #8197

Merged
merged 10 commits into from
Jan 6, 2025
Merged

Conversation

naftis
Copy link
Collaborator

@naftis naftis commented Dec 11, 2024

When death is being registered, MOSIP might not have the deceased person's NID, or it's already been deactivated. We want to show this in record audit in such ways:

  • NID "1234567890" deactivated
  • NID "1234567890" already deactivated
  • NID "1234567890" not found

This change allows supplying a comment when running confirmRegistration from the integration.

This comment has been minimized.

@naftis naftis added 🚀 Ready to deploy Deployment automation should pick this PR up and start auto-deploying it and removed 🚧 work in progress labels Dec 16, 2024
@ocrvs-bot
Copy link
Collaborator

Your environment is deployed to https://ocrvs-8178.opencrvs.dev

@naftis naftis deployed to ocrvs-8178 January 6, 2025 04:07 — with GitHub Actions Active
@naftis naftis merged commit 066ecda into develop Jan 6, 2025
55 of 57 checks passed
@naftis naftis deleted the ocrvs-8178 branch January 6, 2025 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚀 Ready to deploy Deployment automation should pick this PR up and start auto-deploying it 💅 Waiting For Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants